From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751558Ab3KRJi7 (ORCPT ); Mon, 18 Nov 2013 04:38:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33234 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751236Ab3KRJiw (ORCPT ); Mon, 18 Nov 2013 04:38:52 -0500 Date: Mon, 18 Nov 2013 17:37:49 +0800 From: Dave Young To: Toshi Kani Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, x86@kernel.org, mjg59@srcf.ucam.org, hpa@zytor.com, James.Bottomley@HansenPartnership.com, vgoyal@redhat.com, ebiederm@xmission.com, horms@verge.net.au, kexec@lists.infradead.org, bp@alien8.de Subject: Re: [patch 1/7 v2] Add function efi_remap_region for remapping to saved virt address Message-ID: <20131118093749.GA16381@dhcp-16-126.nay.redhat.com> References: <20131105082007.872550445@dhcp-16-126.nay.redhat.com> <20131105082715.502723229@dhcp-16-126.nay.redhat.com> <1384556525.1791.4.camel@misato.fc.hp.com> <20131118020939.GB4025@dhcp-16-126.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131118020939.GB4025@dhcp-16-126.nay.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/18/13 at 10:09am, Dave Young wrote: > On 11/15/13 at 04:02pm, Toshi Kani wrote: > > On Tue, 2013-11-05 at 16:20 +0800, dyoung@redhat.com wrote: > > > Kexec kernel will use saved runtime virtual mapping, so add a > > > new function efi_remap_region to remapping it directly without > > > calculate the virt addr from efi_va. > > > > > > The md is passed in from 1st kernel, the virtual addr is > > > saved in md->virt_addr. > > > > : > > > > > +/* > > > + * kexec kernel will use efi_map_region_fixed to map efi > > > + * runtime memory ranges. md->virt_addr is the original virtual > > > + * address which had been mapped in kexec 1st kernel. > > > + */ > > > +void __init efi_map_region_fixed(efi_memory_desc_t *md) > > > > Can you simply use __map_region() instead of creating this function? > > Both functions seem to do the same thing. (In __map_region(), size and > > end are not used.) > > Matt also suggest to reuse __map_region in another apply, will do. Will remove the unused variables in another patch. -- Thanks Dave