mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	David Ahern <dsahern@gmail.com>,
	linux-kernel@vger.kernel.org,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Petr Machata <pmachata@redhat.com>
Subject: Re: [PATCH] perf top: Make -g refer to callchains
Date: Mon, 18 Nov 2013 21:16:19 +0100	[thread overview]
Message-ID: <20131118201619.GA26312@host2.jankratochvil.net> (raw)
In-Reply-To: <20131118174945.GD24375@krava.brq.redhat.com>

On Mon, 18 Nov 2013 18:49:45 +0100, Jiri Olsa wrote:
> I think it's an option.. but it'll simpler to try the libdw
> interface first and see if it's good/fast enough..

The elfutils libdw unwinder is being upstreamed these weeks, the x86* unwinder
itself is already upstream now.


> also I recall discussing the speed with libdw developer

My tests with perf using elfutils unwinder were 10x faster than libunwind;
this is by some simple caching of ELF files.  Sure a similar cache could be
implemented also for libunwind.  But the cache is a wrong solution.

The problem is that currently perf loads the ELF files again and again for
every process as the ELF file always gets automatically relocated for the
address where it was loaded.  The right way is to load the ELF file only once
and access always the same copy with process-specific displacement only.

I did not investigate how much feasible it is with libunwind.  For elfutils
there is pmachata/sharing unfinished branch from 2008 to implement that.
I have not checked it more before the unwinder gets fully upstreamed.


Jan

  parent reply	other threads:[~2013-11-18 20:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-15  3:51 David Ahern
2013-11-15  5:28 ` Ingo Molnar
2013-11-15  5:46 ` Ingo Molnar
2013-11-18 12:59   ` Arnaldo Carvalho de Melo
2013-11-18 13:25     ` Jiri Olsa
2013-11-18 14:26       ` Ingo Molnar
2013-11-18 17:49         ` Jiri Olsa
2013-11-18 19:17           ` Ingo Molnar
2013-11-18 20:16           ` Jan Kratochvil [this message]
2013-11-19  9:26             ` Jean Pihet
2013-11-19  9:33               ` Jan Kratochvil
2013-11-19  9:24     ` Jean Pihet
2013-11-30 12:49 ` [tip:perf/core] " tip-bot for David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131118201619.GA26312@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=acme@ghostprotocols.net \
    --cc=dsahern@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=pmachata@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome