From: Greg KH <gregkh@linuxfoundation.org>
To: Josh Boyer <jwboyer@redhat.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
devel@driverdev.osuosl.org, Dave Airlie <airlied@gmail.com>,
linux-kernel@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH] staging: imx-drm: Fix modular build of DRM_IMX_IPUV3
Date: Tue, 19 Nov 2013 21:39:19 -0800 [thread overview]
Message-ID: <20131120053919.GB367@kroah.com> (raw)
In-Reply-To: <20131120015659.GF1908@hansolo.jdub.homelinux.org>
On Tue, Nov 19, 2013 at 08:56:59PM -0500, Josh Boyer wrote:
> On Mon, Nov 18, 2013 at 10:03:10AM +0100, Sascha Hauer wrote:
> > On Tue, Nov 12, 2013 at 12:15:45PM -0500, Josh Boyer wrote:
> > > commit b8d181e408af (staging: drm/imx: add drm plane support) added a file
> > > to the make target for DRM_IMX_IPUV3 but didn't adjust the objs required
> > > to actually build that as a module. Kbuild got confused and this lead to
> > > link errors like:
> > >
> > > ERROR: "ipu_plane_disable" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined!
> > > ERROR: "ipu_plane_enable" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined!
> > >
> > > Additionally, it added a call to imx_drm_crtc_id which also fails with a
> > > link error as above. To fix this, we adjust the make target with the proper
> > > objs, which will change the name of the resulting .ko. We also add an
> > > EXPORT_SYMBOL_GPL for imx_drm_crtc_id.
> > >
> > > Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
> >
> >
> > Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
> >
> > Sascha
>
> Thanks. So who picks this fix up? Greg, is that you?
Yes, I will once 3.13-rc1 is out.
greg k-h
next prev parent reply other threads:[~2013-11-20 5:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 17:15 Josh Boyer
2013-11-18 9:03 ` Sascha Hauer
2013-11-20 1:56 ` Josh Boyer
2013-11-20 5:39 ` Greg KH [this message]
2013-11-20 13:16 ` Josh Boyer
2013-11-20 16:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131120053919.GB367@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=airlied@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=jwboyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®