From: "chaowang@redhat.com" <chaowang@redhat.com>
To: Atsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp>
Cc: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>,
"bhe@redhat.com" <bhe@redhat.com>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ebiederm@xmission.com" <ebiederm@xmission.com>,
"dyoung@redhat.com" <dyoung@redhat.com>,
"vgoyal@redhat.com" <vgoyal@redhat.com>
Subject: Re: /proc/vmcore mmap() failure issue
Date: Thu, 21 Nov 2013 15:14:42 +0800 [thread overview]
Message-ID: <20131121071441.GA2207@dhcp16-109.nay.redhat.com> (raw)
In-Reply-To: <0910DD04CBD6DE4193FCF86B9C00BE971C3845@BPXM01GP.gisp.nec.co.jp>
On 11/20/13 at 05:27am, Atsushi Kumagai wrote:
> On 2013/11/19 18:56:21, kexec <kexec-bounces@lists.infradead.org> wrote:
> > (2013/11/18 9:51), Atsushi Kumagai wrote:
> > > (2013/11/15 23:26), Vivek Goyal wrote:
> > >> On Fri, Nov 15, 2013 at 06:41:52PM +0900, HATAYAMA Daisuke wrote:
> > >>
> > >> [..]
> > >>>> Given the fact that hpa does not like fixing it in kernel. We are
> > >>>> left with option of fixing it in following places.
> > >>>>
> > >>>> - Drop partial pages in kexec-tools
> > >>>> - Drop partial pages in makeudmpfile.
> > >>>> - Read partial pages using read() interface in makedumpfile
> > >>>> - Modify /proc/vmcore to copy partial pages in second kernel's memory.
> > >>>>
> > >>>> It is not clear to me that partial pages are really useful. So I
> > >>>> want to avoid modifying /proc/vmcore to deal with partial pages and
> > >>>> increase complexity.
> > >>>>
> > >>>> So fixing makedumpfile (either option2 or option 3) seems least
> > >>>> risky to me. In fact I would say let us keep it simple and truncate
> > >>>> partial pages in makedumpfile to keep it simple. And look at option
> > >>>> 3 once we have a strong use case for partial pages.
> > >>>>
> > >>>> What do you think?
> > >>>>
> > >>>
> > >>> As you say, it's not clear that partial pages are really useful, but
> > >>> on the other hand, it seems to me not clear that they are really useless.
> > >>> I think we should get them as long as we have access to them.
> > >>>
> > >>> It seems best to me the option 3). Switching between read and mmap
> > >>> would be not so complex and also it's by far flexible in
> > >>> makedumpfile than in kernel.
> > >>
> > >> Ok, I am fine with option 3. It is more complicated option but safe
> > >> option.
> > >
> > > It sounds reasonable also to me.
> > >
> > >> Is there any chance that you could look into fixing this. I have no
> > >> experience writing code for makedumpfile.
> > >
> > > I'll send a patch to fix this soon.
> > >
> >
> > Thanks.
> >
> > BTW, now the following patch has been applied on top of makedumpfile in kexec-tools package on fedora in order to avoid the issue.
> >
> > https://lists.fedoraproject.org/pipermail/kexec/2013-November/000254.html
> >
> > I remember prototype version of mmap patch implemented a kind of --no-mmap option and we could use it to disable mmap() use and use read() instead, I think which is useful when we face this kind of issue.
>
> How about this fail back structure instead of such an extra option ?
>
> Thanks
> Atsushi Kumagai
>
> From: Atsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp>
> Date: Wed, 20 Nov 2013 14:10:19 +0900
> Subject: [PATCH] Fall back to read() when mmap() fails.
>
> Signed-off-by: Atsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp>
> ---
> makedumpfile.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/makedumpfile.c b/makedumpfile.c
> index ca03440..f583602 100644
> --- a/makedumpfile.c
> +++ b/makedumpfile.c
> @@ -324,7 +324,15 @@ read_from_vmcore(off_t offset, void *bufptr, unsigned long size)
> if (!read_with_mmap(offset, bufptr, size)) {
> ERRMSG("Can't read the dump memory(%s) with mmap().\n",
> info->name_memory);
> - return FALSE;
> +
> + ERRMSG("This kernel might have some problems about mmap().\n");
> + ERRMSG("read() will be used instead of mmap() from now.\n");
> +
> + /*
> + * Fall back to read().
> + */
> + info->flag_usemmap = FALSE;
> + read_from_vmcore(offset, bufptr, size);
Hi, Atsushi
I've got such a workstation too. And I confirm this patch works for me.
However, I have a question:
Why not switch to mmap() back after read()?
Thanks
WANG Chao
> }
> } else {
> if (lseek(info->fd_memory, offset, SEEK_SET) == failed) {
> --
> 1.8.0.2
next prev parent reply other threads:[~2013-11-21 7:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 20:41 Vivek Goyal
2013-11-13 21:04 ` Vivek Goyal
2013-11-13 21:14 ` H. Peter Anvin
2013-11-13 22:41 ` Vivek Goyal
2013-11-13 22:44 ` H. Peter Anvin
2013-11-13 23:00 ` Vivek Goyal
2013-11-13 23:08 ` H. Peter Anvin
2013-11-14 10:31 ` HATAYAMA Daisuke
2013-11-14 15:13 ` Vivek Goyal
2013-11-15 9:41 ` HATAYAMA Daisuke
2013-11-15 14:26 ` Vivek Goyal
2013-11-18 0:51 ` Atsushi Kumagai
2013-11-18 13:55 ` Vivek Goyal
2013-11-20 5:29 ` Atsushi Kumagai
2013-11-20 14:59 ` Vivek Goyal
2013-11-21 5:00 ` Atsushi Kumagai
2013-11-21 8:31 ` HATAYAMA Daisuke
2013-11-21 16:52 ` Vivek Goyal
2013-11-25 8:10 ` Atsushi Kumagai
2013-11-25 9:01 ` HATAYAMA Daisuke
2013-11-25 14:41 ` Vivek Goyal
2013-11-26 1:51 ` Atsushi Kumagai
2013-11-26 5:16 ` HATAYAMA Daisuke
2013-11-19 9:55 ` HATAYAMA Daisuke
2013-11-20 5:27 ` Atsushi Kumagai
2013-11-20 6:43 ` HATAYAMA Daisuke
2013-11-26 1:52 ` Atsushi Kumagai
2013-11-21 7:14 ` chaowang [this message]
2013-11-25 8:09 ` Atsushi Kumagai
2013-11-26 3:29 ` chaowang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131121071441.GA2207@dhcp16-109.nay.redhat.com \
--to=chaowang@redhat.com \
--cc=bhe@redhat.com \
--cc=d.hatayama@jp.fujitsu.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®