From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754387Ab3KUNPd (ORCPT ); Thu, 21 Nov 2013 08:15:33 -0500 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.226]:44366 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752807Ab3KUNPc (ORCPT ); Thu, 21 Nov 2013 08:15:32 -0500 Date: Thu, 21 Nov 2013 08:15:29 -0500 From: Steven Rostedt To: Jiri Olsa Cc: linux-kernel@vger.kernel.org, Corey Ashford , Frederic Weisbecker , Ingo Molnar , Namhyung Kim , Paul Mackerras , Peter Zijlstra , Arnaldo Carvalho de Melo , David Ahern Subject: Re: [PATCH 07/22] tools lib traceevent: Add kvm plugin Message-ID: <20131121081529.3d43f71f@gandalf.local.home> In-Reply-To: <1385031680-9014-8-git-send-email-jolsa@redhat.com> References: <1385031680-9014-1-git-send-email-jolsa@redhat.com> <1385031680-9014-8-git-send-email-jolsa@redhat.com> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.20; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 21 Nov 2013 12:01:05 +0100 Jiri Olsa wrote: > Backporting kvm plugin. > > Backported from Steven Rostedt's trace-cmd repo (HEAD 0f2c2fb): > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git > > This plugin adds field resolving functions for following > tracepoint events: > kvm:kvm_exit > kvm:kvm_emulate_insn > kvm:kvm_nested_vmexit > kvm:kvm_nested_vmexit_inject > kvmmmu:kvm_mmu_get_page > kvmmmu:kvm_mmu_sync_page > kvmmmu:kvm_mmu_unsync_page > kvmmmu:kvm_mmu_zap_page > kvmmmu:kvm_mmu_prepare_zap_page > > The diff of 'perf script' output generated by old and new code: > (data was generated by 'perf record -e 'kvm:*,kvmmmu:*' -a') > > --- script.kvm.old > +++ script.kvm.new > qemu-system-x86 17414 [000] 6868.995053: kvm:kvm_exit: reason EPT_VIOLATION rip 0xfff0 info 184 0 > qemu-system-x86 17414 [000] 6868.995109: kvm:kvm_emulate_insn: f0000:c46b:e4 71 (real) > - qemu-system-x86 3006 [002] 10562.079422: kvmmmu:kvm_mmu_get_page: [FAILED TO PARSE] mmu_valid_gen=0x2 gfn=0 role=122884 root_count=0 unsync=0 created=1 > + qemu-system-x86 3006 [002] 10562.079422: kvmmmu:kvm_mmu_get_page: new sp gfn 0 0/4 q0 direct --- !pge !nxe root 0 sync > - qemu-system-x86 3006 [002] 10562.080502: kvmmmu:kvm_mmu_prepare_zap_page: [FAILED TO PARSE] mmu_valid_gen=0x2 gfn=0 role=122884 root_count=1 unsync=0 > + qemu-system-x86 3006 [002] 10562.080502: kvmmmu:kvm_mmu_prepare_zap_page: 0/4 q0 direct --- !pge !nxe root 1 sync > qemu-system-x86 3290 [002] 10708.755312: kvmmmu:fast_page_fault: [FAILED TO PARSE] vcpu_id=0 gva=4094486080 error_code=3 sptep=0xffff88019f1e3670 old_spte=336391285 new_spte=336391287 retry=1 > - insmod 2576 [001] 781.731666: kvmmmu:kvm_mmu_sync_page: [FAILED TO PARSE] mmu_valid_gen=0x1 gfn=2 role=24624 root_count=10 unsync=1 > + insmod 2576 [001] 781.731666: kvmmmu:kvm_mmu_sync_page: 3/0 q0 --- !pge !nxe root 10 unsync > - insmod 2576 [001] 781.731668: kvmmmu:kvm_mmu_unsync_page: [FAILED TO PARSE] mmu_valid_gen=0x1 gfn=2 role=24624 root_count=10 unsync=1 > + insmod 2576 [001] 781.731668: kvmmmu:kvm_mmu_unsync_page: 3/0 q0 --- !pge !nxe root 10 unsync > > Note: > - kvm_mmu_zap_page is replaced by kvm_mmu_prepare_zap_page > in current kernel, keeping it for backward compatibility > - some of the tracepoints keep the same output even with > the plugin handling: kvm:kvm_exit, kvm:kvm_emulate_insn > - the 'kvmmmu:fast_page_fault' is still broken because of > missing is_writable_pte function and is fixed in another patch > - ommited following tracepoints from backport because > the output was buggy > kvm:kvm_nested_vmexit > kvm:kvm_nested_vmexit_inject > > Signed-off-by: Jiri Olsa > Cc: Corey Ashford > Cc: Frederic Weisbecker > Cc: Ingo Molnar > Cc: Namhyung Kim > Cc: Paul Mackerras > Cc: Peter Zijlstra > Cc: Arnaldo Carvalho de Melo > Cc: Steven Rostedt Signed-off-by: Steven Rostedt -- Steve > Cc: David Ahern > ---