From: Mark Brown <broonie@kernel.org>
To: Florian Meier <florian.meier@koalo.de>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Lars-Peter Clausen <lars@metafoo.de>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
linux-rpi-kernel <linux-rpi-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
dmaengine <dmaengine@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCHv4] ASoC: Add support for BCM2835
Date: Fri, 22 Nov 2013 14:05:19 +0000 [thread overview]
Message-ID: <20131122140519.GN14725@sirena.org.uk> (raw)
In-Reply-To: <528F5CE3.30105@koalo.de>
[-- Attachment #1: Type: text/plain, Size: 376 bytes --]
On Fri, Nov 22, 2013 at 02:32:19PM +0100, Florian Meier wrote:
> > + dev = devm_kzalloc(&pdev->dev, sizeof(*dev),
> > + GFP_KERNEL);
> > + if (IS_ERR(base))
> > + return PTR_ERR(base);
> Found a typo here, should be IS_ERR(dev) and PTR_ERR(dev).
No, it should be a check for NULL and returning -ENOMEM.
> Is the patch acceptable apart from that now?
Not looked yet.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-11-22 14:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 18:17 Florian Meier
2013-11-22 13:32 ` Florian Meier
2013-11-22 14:05 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131122140519.GN14725@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=florian.meier@koalo.de \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®