From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755682Ab3KVSFF (ORCPT ); Fri, 22 Nov 2013 13:05:05 -0500 Received: from mail-pd0-f179.google.com ([209.85.192.179]:55359 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752565Ab3KVSFD (ORCPT ); Fri, 22 Nov 2013 13:05:03 -0500 Date: Fri, 22 Nov 2013 10:05:01 -0800 From: Guenter Roeck To: Laszlo Papp Cc: Marcus Folkesson , hjk@hansjkoch.de, linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org Subject: Re: [lm-sensors] [PATCH] hwmon: (max6650) Add support for gpiodef Message-ID: <20131122180501.GA8547@roeck-us.net> References: <20131119180007.GB16693@roeck-us.net> <20131121173458.GC10783@roeck-us.net> <528F6BB8.8040504@roeck-us.net> <20131122160457.GA3951@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 22, 2013 at 05:47:33PM +0000, Laszlo Papp wrote: > On Fri, Nov 22, 2013 at 4:04 PM, Guenter Roeck wrote: > > On Fri, Nov 22, 2013 at 02:50:50PM +0000, Laszlo Papp wrote: > >> On Fri, Nov 22, 2013 at 2:35 PM, Guenter Roeck wrote: > >> > On 11/22/2013 01:23 AM, Laszlo Papp wrote: > >> >> > >> >> Just to clarify: you want to have ./gpio/gpio-max6650.c? > >> >> > >> > No, I never said that. I wanted you to register the gpio pins > >> > with the gpio subsystem. I didn't ask you to write a separate > >> > driver for it. > >> > > >> > Sure, strictly speaking one could write a top level mfd driver > >> > and separate gpio and hwmon drivers, but at least in my opinion > >> > that would be overkill. I also never suggested this; you brought > >> > the term mfd into the discussion. > >> > >> Why is it an overkill to write a separate gpio driver for this, and > >> potentially also for the gpio status register of this particular MAXIM > >> chip? > >> > >> Other gpio drivers in the gpio folder are also short. This would not > >> become long either. > >> > > No one prevents you from writing a separate gpio driver. I will certainly > > not prevent you from doing it. Just don't claim that I requested it. > > Same is true for an mfd driver; I won't prevent you from writing one. > > But don't claim that I told you to do it. > > I am not sure if you are trying to claim that with this statement a > separate gpio driver would be acceptable, but it would require a bit > more work, or whether that you would reject such a driver added. > Please explain, for my education, what makes you believe that I would object to or reject to anyone submitting such a driver. Thanks, Guenter