From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756418Ab3KWWi3 (ORCPT ); Sat, 23 Nov 2013 17:38:29 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:60780 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751804Ab3KWWiZ (ORCPT ); Sat, 23 Nov 2013 17:38:25 -0500 Date: Sat, 23 Nov 2013 14:46:57 -0800 (PST) Message-Id: <20131123.144657.1317547893471212174.davem@davemloft.net> To: vyasevich@gmail.com Cc: changxiangzhong@gmail.com, nhorman@tuxdriver.com, linux-sctp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: sctp: find the correct highest_new_tsn in sack From: David Miller In-Reply-To: <528E85A9.3000703@gmail.com> References: <1385070988-29554-1-git-send-email-changxiangzhong@gmail.com> <528E85A9.3000703@gmail.com> X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.1 (shards.monkeyblade.net [0.0.0.0]); Sat, 23 Nov 2013 14:38:25 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vlad Yasevich Date: Thu, 21 Nov 2013 17:14:01 -0500 > On 11/21/2013 04:56 PM, Chang Xiangzhong wrote: >> Function sctp_check_transmitted(transport t, ...) would iterate all of >> transport->transmitted queue and looking for the highest __newly__ acked tsn. >> The original algorithm would depend on the order of the assoc->transport_list >> (in function sctp_outq_sack line 1215 - 1226). The result might not be the >> expected due to the order of the tranport_list. >> >> Solution: checking if the exising is smaller than the new one before assigning >> >> Signed-off-by: Chang Xiangzhong > > Good find. This has been around for since day 1. It doesn't so much > depend on the order of the transport list, but on the order the > transports been used. I agree it is a problem if chunks have been > distributed across multiple transports and a singe SACK acking them all. > > Acked-by: Vlad Yasevich Applied, thanks.