From: Sebastian Reichel <sre@debian.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Grant Likely <grant.likely@secretlab.ca>,
linux-iio@vger.kernel.org, Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Landley <rob@landley.net>, Jonathan Cameron <jic23@cam.ac.uk>,
Peter Meerwald <pmeerw@pmeerw.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bill Pemberton <wfp5p@virginia.edu>,
Sachin Kamat <sachin.kamat@linaro.org>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio:light:tsl2563: Add DT support
Date: Sat, 23 Nov 2013 13:06:06 +0100 [thread overview]
Message-ID: <20131123120606.GA21861@earth.universe> (raw)
In-Reply-To: <52909685.6040606@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1174 bytes --]
On Sat, Nov 23, 2013 at 11:50:29AM +0000, Jonathan Cameron wrote:
> On 10/26/13 00:09, Sebastian Reichel wrote:
> > Hi Grant,
> >
> > On Fri, Oct 25, 2013 at 08:10:28PM +0100, Grant Likely wrote:
> >>> + - cover-comp-gain : integer used as multiplier for gain + compensation (default = 1)
> >>
> >> Should be taos,cover-comp-gain
> >
> > Has been updated to "amstaos,cover-comp-gain" in the latest patches, see https://lkml.org/lkml/2013/10/25/59
> >
> >> Otherwise looks fine to me.
> >
> > Is this an acked-by?
> It's good enough for me to take the patch :)
> >
> >>> + else if (np) + of_property_read_u32_index(np, "cover-comp-gain", 0, + &chip->cover_comp_gain);
> >>
> >> of_property_read_u32() should be sufficient. You don't need the _index variant.
> >
> > ah, I missed the function when skipping over linux/of.h. I will sent another update.
>
> Did you do this? Latest I seem to have is V3 and that doesn't have
> this change.
Sorry, I forgot, that I still had work to do for this patch :(
> I've made the obvious change to your V3 and applied it.
Thanks for taking care of it.
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-11-23 12:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 21:51 Sebastian Reichel
2013-10-24 8:29 ` Jonathan Cameron
2013-10-24 13:43 ` Sebastian Reichel
2013-10-24 13:58 ` Jon Brenner
2013-10-24 15:13 ` Jonathan Cameron
2013-10-24 14:27 ` [PATCHv2] " Sebastian Reichel
2013-10-25 3:32 ` Kumar Gala
2013-10-25 8:23 ` Sebastian Reichel
2013-10-25 8:37 ` Kumar Gala
2013-10-25 9:10 ` [PATCHv3] " Sebastian Reichel
2013-11-23 11:52 ` Jonathan Cameron
2013-10-25 19:10 ` [PATCH] " Grant Likely
2013-10-25 23:09 ` Sebastian Reichel
2013-11-23 11:50 ` Jonathan Cameron
2013-11-23 12:06 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131123120606.GA21861@earth.universe \
--to=sre@debian.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jic23@cam.ac.uk \
--cc=jic23@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sachin.kamat@linaro.org \
--cc=swarren@wwwdotorg.org \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®