From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752902Ab3KXQTR (ORCPT ); Sun, 24 Nov 2013 11:19:17 -0500 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:41533 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751343Ab3KXQTO (ORCPT ); Sun, 24 Nov 2013 11:19:14 -0500 Date: Sun, 24 Nov 2013 16:18:58 +0000 From: One Thousand Gnomes To: Peter Hurley Cc: Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH tty-next 5/7] n_tty: Refactor input_available_p() by call site Message-ID: <20131124161858.626cc9b2@alan.etchedpixels.co.uk> In-Reply-To: <52915E14.7000703@hurleysoftware.com> References: <1385135965-4235-1-git-send-email-peter@hurleysoftware.com> <1385135965-4235-6-git-send-email-peter@hurleysoftware.com> <20131124002650.74902872@alan.etchedpixels.co.uk> <52915E14.7000703@hurleysoftware.com> Organization: Intel Corporation X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.20; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 23 Nov 2013 21:01:56 -0500 Peter Hurley wrote: > On 11/23/2013 07:26 PM, One Thousand Gnomes wrote: > > On Fri, 22 Nov 2013 10:59:23 -0500 > > Peter Hurley wrote: > > > >> Distinguish if caller is n_tty_poll() or n_tty_read(), and > >> set the read/wakeup threshold accordingly. > >> > >> Signed-off-by: Peter Hurley > > > > Doh ignore previous.. yes that patch is right. I should pay attention to > > 0/7 8) > > Maybe I should add more to the commit message from the cover letter > description ? Maybe I should just read the code more carefully 8). Alan