From: Mark Rutland <mark.rutland@arm.com>
To: Rob Herring <robherring2@gmail.com>
Cc: Kumar Gala <galak@codeaurora.org>,
devicetree <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Will Deacon <Will.Deacon@arm.com>,
Pawel Moll <Pawel.Moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>
Subject: Re: [PATCH] dt-bindings: add ARMv8 PMU binding
Date: Mon, 25 Nov 2013 16:01:53 +0000 [thread overview]
Message-ID: <20131125160153.GI32081@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <CAL_JsqKArowT_DE8-vCJvmOSxjp+X9bngCXXsgjBK7G3wPZ7wA@mail.gmail.com>
On Mon, Nov 25, 2013 at 03:24:46PM +0000, Rob Herring wrote:
> On Mon, Nov 25, 2013 at 3:16 AM, Mark Rutland <mark.rutland@arm.com> wrote:
> > On Fri, Nov 22, 2013 at 09:43:31PM +0000, Rob Herring wrote:
> >> On 11/22/2013 03:38 PM, Kumar Gala wrote:
> >> >
> >> > On Nov 22, 2013, at 3:17 PM, Rob Herring <robherring2@gmail.com> wrote:
> >> >
> >> >> From: Rob Herring <rob.herring@calxeda.com>
> >> >>
> >> >> Add missing "arm,armv8-pmuv3" compatible property for ARMv8 PMU.
> >> >>
> >> >> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> >> >> Cc: Will Deacon <will.deacon@arm.com>
> >> >> Cc: Pawel Moll <pawel.moll@arm.com>
> >> >> Cc: Mark Rutland <mark.rutland@arm.com>
> >> >> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> >> >> ---
> >> >> Documentation/devicetree/bindings/arm/pmu.txt | 1 +
> >> >> 1 file changed, 1 insertion(+)
> >> >>
> >> >> diff --git a/Documentation/devicetree/bindings/arm/pmu.txt b/Documentation/devicetree/bindings/arm/pmu.txt
> >> >> index 343781b..3e1e498 100644
> >> >> --- a/Documentation/devicetree/bindings/arm/pmu.txt
> >> >> +++ b/Documentation/devicetree/bindings/arm/pmu.txt
> >> >> @@ -7,6 +7,7 @@ representation in the device tree should be done as under:-
> >> >> Required properties:
> >> >>
> >> >> - compatible : should be one of
> >> >> + "arm,armv8-pmuv3”
> >> >
> >> > what about arm,armv8-pmu-v3?
> >>
> >> I'm just documenting what is already being used:
> >>
> >> arch/arm64/boot/dts/foundation-v8.dts: compatible =
> >> "arm,armv8-pmuv3";
> >> arch/arm64/boot/dts/rtsm_ve-aemv8a.dts: compatible =
> >> "arm,armv8-pmuv3";
> >>
> >> Do we want to change those?
> >
> > It would probably have been nicer to have the '-' from the start, but
> > adding it now is only going to expand the set of compatible strings for
> > no appreciable benefit.
> >
> > I don't see any value in adding a new form of the string, and we can't
> > change the existing one as it's already in use.
>
> Is that an ack then?
>
Sure:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
prev parent reply other threads:[~2013-11-25 16:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 21:17 Rob Herring
2013-11-22 21:38 ` Kumar Gala
2013-11-22 21:43 ` Rob Herring
2013-11-25 9:16 ` Mark Rutland
2013-11-25 15:24 ` Rob Herring
2013-11-25 16:01 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131125160153.GI32081@e106331-lin.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=Pawel.Moll@arm.com \
--cc=Will.Deacon@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=robherring2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®