From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756628Ab3KYQEO (ORCPT <rfc822;w@1wt.eu>);
	Mon, 25 Nov 2013 11:04:14 -0500
Received: from mx1.redhat.com ([209.132.183.28]:14634 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752093Ab3KYQEK (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 Nov 2013 11:04:10 -0500
Date: Mon, 25 Nov 2013 17:03:45 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: linux-kernel@vger.kernel.org, Corey Ashford <cjashfor@linux.vnet.ibm.com>,
        Frederic Weisbecker <fweisbec@gmail.com>, Ingo Molnar <mingo@elte.hu>,
        Paul Mackerras <paulus@samba.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Steven Rostedt <rostedt@goodmis.org>, David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH 21/22] perf tools: Add trace-event global object for
 tracepoint interface
Message-ID: <20131125160345.GJ3161@krava.brq.redhat.com>
References: <1385031680-9014-1-git-send-email-jolsa@redhat.com>
 <1385031680-9014-22-git-send-email-jolsa@redhat.com>
 <1385135234.1747.122.camel@leonhard>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1385135234.1747.122.camel@leonhard>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Nov 23, 2013 at 12:47:14AM +0900, Namhyung Kim wrote:
> 2013-11-21 (목), 12:01 +0100, Jiri Olsa:
> > In order to get the proper plugins processing we need to
> > use full trace-event interface when creating tracepoint
> > events. So far we were using shortcut to get the parsed
> > format.
> > 
> > Moving current 'event_format__new' function into trace-event
> > object as 'trace_event__tp_format'.
> > 
> > This function uses properly initialized global trace-event
> > object, ensuring proper plugins processing.
> 
> I see this when I compile it on my old ubuntu 10.04 box (with gcc 4.4.3)
> 
>   CC       util/trace-event.o
> cc1: warnings being treated as errors
> util/trace-event.c: In function 'trace_event__tp_format':
> util/trace-event.c:63: error: not protecting function: no buffer at
> least 8 bytes long
> make[1]: *** [util/trace-event.o] Error 1

hum, what was the stackprotector status?

...                stackprotector: [ on  ]
...            stackprotector-all: [ on  ]


thanks,
jirka