mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Mike Galbraith <efault@gmx.de>,
	Stephane Eranian <eranian@google.com>,
	David Ahern <dsahern@gmail.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCHv2] perf tools: Fix tags/TAGS targets rebuilding
Date: Tue, 26 Nov 2013 13:54:12 +0100	[thread overview]
Message-ID: <20131126125412.GJ1267@krava.brq.redhat.com> (raw)
In-Reply-To: <20131126120055.GA6103@gmail.com>

On Tue, Nov 26, 2013 at 01:00:55PM +0100, Ingo Molnar wrote:
> 
> * Jiri Olsa <jolsa@redhat.com> wrote:
> 
> > On Tue, Nov 26, 2013 at 12:31:08PM +0100, Ingo Molnar wrote:

SNIP

> > > 
> > > Also note that we have duplicate code for this in Makefile.perf 
> > > already. Would it be possible to pass through this there and keep the 
> > > main Makefile is just a thin, minimal wrapper that adds default 
> > > parallelism, etc?
> > 
> > well, thats what I actually tried to do.. pass the
> > processing to the Makefile.perf otherwise it stops
> > in Makefile
> > 
> > I guess you want some generic way of doing that
> 
> If it's just these two phony targets that need to be in the main 
> makefile then I guess your approach is the simplest one and we should 
> do it like that instead of complicating the interface. If it gets 
> messier in the future we can reconsider?
> 

sounds good, pelase check v2

thanks,
jirka


---
Once the tags/TAGS file is generated it's never rebuilt
until it's removed by hand.

The reason is that the Makefile does not treat tags/TAGS
as targets but as files and thus won't rebuilt them
once they are in place.

Adding PHONY tags/TAGS targets into Makefile.

Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Stephane Eranian <eranian@google.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/Makefile | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 4835618..eefb9fb 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -60,8 +60,11 @@ endef
 
 #
 # Needed if no target specified:
+# (Except for tags and TAGS targets. The reason is that the
+# Makefile does not treat tags/TAGS as targets but as files
+# and thus won't rebuilt them once they are in place.)
 #
-all:
+all tags TAGS:
	$(print_msg)
	$(make)
 
@@ -77,3 +80,5 @@ clean:
 %:
	$(print_msg)
	$(make)
+
+.PHONY: tags TAGS
-- 
1.8.3.1


  reply	other threads:[~2013-11-26 12:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-26 11:21 [PATCH] perf tools: Fix tags target rebuilding Jiri Olsa
2013-11-26 11:31 ` Ingo Molnar
2013-11-26 11:50   ` Jiri Olsa
2013-11-26 12:00     ` Ingo Molnar
2013-11-26 12:54       ` Jiri Olsa [this message]
2013-11-26 16:13         ` [PATCHv2] perf tools: Fix tags/TAGS targets rebuilding Ingo Molnar
2013-11-26 23:16           ` Jiri Olsa
2013-11-27 11:31             ` Ingo Molnar
2013-11-27 19:40             ` Arnaldo Carvalho de Melo
2013-11-30 12:54         ` [tip:perf/core] " tip-bot for Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131126125412.GJ1267@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=dsahern@gmail.com \
    --cc=efault@gmx.de \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®