mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Frederic Weisbecker <fweisbec@gmail.com>
Subject: [PATCH 0/2] [GIT PULL] tracing: Fix event null strings and function graph with modules
Date: Tue, 26 Nov 2013 20:38:41 -0500	[thread overview]
Message-ID: <20131127013841.321519823@goodmis.org> (raw)

This includes two fixes.

1) is a bug fix that happens when root does the following:

  echo function_graph > current_tracer
  modprobe foo
  echo nop > current_tracer

This causes the ftrace internal accounting to get screwed up and
crashes ftrace, preventing the user from using the function tracer
after that.

2) if a TRACE_EVENT has a string field, and NULL is given for it.

The internal trace event code does a strlen() and strcpy() on the
source of field. If it is NULL it causes the system to oops.

This bug has been there since 2.6.31, but no TRACE_EVENT ever passed
in a NULL to the string field, until now.

  git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
trace-fixes-v3.13-rc1

Tag SHA1: 8186830c5ab0c57fae8e081ef0321443d8acb14c
Head SHA1: 8a56d7761d2d041ae5e8215d20b4167d8aa93f51


Steven Rostedt (Red Hat) (2):
      tracing: Allow events to have NULL strings
      ftrace: Fix function graph with loading of modules

----
 include/trace/ftrace.h |  5 ++--
 kernel/trace/ftrace.c  | 64 +++++++++++++++++++++++++++-----------------------
 2 files changed, 38 insertions(+), 31 deletions(-)

             reply	other threads:[~2013-11-27  1:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-27  1:38 Steven Rostedt [this message]
2013-11-27  1:38 ` [PATCH 1/2] tracing: Allow events to have NULL strings Steven Rostedt
2013-11-27  1:38 ` [PATCH 2/2] ftrace: Fix function graph with loading of modules Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131127013841.321519823@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®