From: Andrew Morton <akpm@linux-foundation.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-parport@lists.infradead.org,
Maximilian Attems <maks@stro.at>
Subject: Re: [PATCH] parport: parport_pc: remove double PCI ID for NetMos
Date: Wed, 27 Nov 2013 13:53:22 -0800 [thread overview]
Message-ID: <20131127135322.49ea91c23db4879f97b524f0@linux-foundation.org> (raw)
In-Reply-To: <1385570623-20260-1-git-send-email-bigeasy@linutronix.de>
On Wed, 27 Nov 2013 17:43:43 +0100 Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> In commit 85747f ("PATCH] parport: add NetMOS 9805 support") Max added
> the PCI ID for NetMOS 9805 based on a Debian bug report from 2k4 which
> was at the v2.4.26 time frame. The patch made into 2.6.14.
> Shortly before that patch akpm merged commit 296d3c783b ("[PATCH] Support
> NetMOS based PCI cards providing serial and parallel ports") which made
> into v2.6.9-rc1.
> Now we have two different entries for the same PCI id.
> I have here the NetMos 9805 which claims to support SPP/EPP/ECP mode.
> This patch takes Max's entry for titan_1284p1 (base != -1 specifies the
> ioport for ECP mode) and replaces akpm's entry for netmos_9805 which
> specified -1 (=none). Both share the same PCI-ID (my card has subsystem
> 0x1000 / 0x0020 so it should match PCI_ANY).
>
> While here I also drop the entry for titan_1284p2 which is the same as
> netmos_9815.
Does this change have any runtime-visible effects?
next prev parent reply other threads:[~2013-11-27 21:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 16:43 Sebastian Andrzej Siewior
2013-11-27 21:53 ` Andrew Morton [this message]
2013-11-28 10:35 ` Sebastian Andrzej Siewior
2013-12-02 21:44 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131127135322.49ea91c23db4879f97b524f0@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parport@lists.infradead.org \
--cc=maks@stro.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome