From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757370Ab3K0TUa (ORCPT ); Wed, 27 Nov 2013 14:20:30 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:50651 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751648Ab3K0TU3 (ORCPT ); Wed, 27 Nov 2013 14:20:29 -0500 Date: Wed, 27 Nov 2013 11:20:28 -0800 From: Greg KH To: Frank Haverkamp Cc: linux-kernel@vger.kernel.org, arnd@arndb.de, cody@linux.vnet.ibm.com, schwidefsky@de.ibm.com, utz.bacher@de.ibm.com, mmarek@suse.cz, rmallon@gmail.com, jsvogt@de.ibm.com, MIJUNG@de.ibm.com, cascardo@linux.vnet.ibm.com, michael@ibmra.de Subject: Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery Message-ID: <20131127192028.GB28409@kroah.com> References: <1383741943-14609-1-git-send-email-haver@linux.vnet.ibm.com> <1383741943-14609-2-git-send-email-haver@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1383741943-14609-2-git-send-email-haver@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 06, 2013 at 01:45:38PM +0100, Frank Haverkamp wrote: > +/* > + * Flags for extended output (dbg_print) > + * We define different levels of debugging for the appropriate unit. > + */ > +#define dbg_card 0x00000001 > +#define dbg_card_ddcb 0x00000004 > +#define dbg_card_regs 0x00000008 > +#define dbg_card_sglist 0x00000400 > +#define dbg_card_pinning 0x00000800 > + > +#define genwqe_dprintk(_cd, dbg_unit, fmt, ...) do { \ > + struct genwqe_dev *__cd = (_cd); \ > + if ((_cd)->debug & (dbg_unit)) \ > + dev_info(&__cd->pci_dev->dev, fmt, \ > + ## __VA_ARGS__); \ > + } while (0) Ugh, really? How is a debugging printk being sent out with dev_info()? And why not just use dynamic kernel debugging and not create your own masks and macros? We are trying to make everything use the same infrastructure, please don't create new ones for every individual driver in the kernel, that's a mess. thanks, greg k-h