mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Amit Virdi <amit.virdi@st.com>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"marc.zyngier@arm.com" <marc.zyngier@arm.com>,
	"nico@linaro.org" <nico@linaro.org>,
	"marc.ceeeee@gmail.com" <marc.ceeeee@gmail.com>,
	"spear--sw-devel@codex.cro.st.com"
	<spear--sw-devel@codex.cro.st.com>
Subject: Re: [PATCH] ARM: asm: Configure caches as per the defconfig
Date: Thu, 28 Nov 2013 10:11:54 +0000	[thread overview]
Message-ID: <20131128101154.GT16735@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <5296D7DF.202@st.com>

On Thu, Nov 28, 2013 at 11:12:55AM +0530, Amit Virdi wrote:
> On 11/27/2013 5:44 PM, Russell King - ARM Linux wrote:
>> On Wed, Nov 27, 2013 at 05:24:04PM +0530, Amit Virdi wrote:
>>> From: Amit VIRDI <Amit.VIRDI@st.com>
>>>
>>> In the current implementation of the decompression code, the caches are enabled
>>> irrespective of their configuration in the deconfig. This makes setting the
>>> ICACHE and DCACHE disable options from the menuconfig irrelevant. Change this
>>> implementation to enable caches only if specified in the defconfig.
>>
>> NAK.  These options are provided more for ARM Ltd's validation of CPUs
>> rather than for users, and it's not supposed to be used with the
>> decompressor.
>>
>
> It is perfectly true that these options are used only during CPU  
> validations and not in the end product. Still, it doesn't justify why  
> these options are not to be used with decompressor. Or alternately, why  
> would a user intend to disable a cache when it has been implemented  
> correctly and is stable? Without this change, the effect of disabling  
> cache is not reflected in entirety.

When doing CPU validations, the compressed image isn't used.

  reply	other threads:[~2013-11-28 10:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-27 11:54 Amit Virdi
2013-11-27 12:14 ` Russell King - ARM Linux
2013-11-28  5:42   ` Amit Virdi
2013-11-28 10:11     ` Russell King - ARM Linux [this message]
2013-11-28 11:45       ` Amit Virdi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131128101154.GT16735@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=amit.virdi@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.ceeeee@gmail.com \
    --cc=marc.zyngier@arm.com \
    --cc=nico@linaro.org \
    --cc=spear--sw-devel@codex.cro.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®