mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: davem@davemloft.net, linux-crypto@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/10] crypto: scatterwalk - Set the chain pointer indication bit
Date: Thu, 28 Nov 2013 22:21:30 +0800	[thread overview]
Message-ID: <20131128142130.GC32124@gondor.apana.org.au> (raw)
In-Reply-To: <20131112174610.19746.91705.stgit@tlendack-t1.amdoffice.net>

On Tue, Nov 12, 2013 at 11:46:10AM -0600, Tom Lendacky wrote:
> The scatterwalk_crypto_chain function invokes the scatterwalk_sg_chain
> function to chain two scatterlists, but the chain pointer indication
> bit is not set.  When the resulting scatterlist is used, for example,
> by sg_nents to count the number of scatterlist entries, a segfault occurs
> because sg_nents does not follow the chain pointer to the chained scatterlist.
> 
> Update scatterwalk_sg_chain to set the chain pointer indication bit as is
> done by the sg_chain function.
> 
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>

Patch applied.  Thanks!

We should also get rid of the crypto-specific SG helpers since
the generic SG helpers are now available everywhere.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2013-11-28 14:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-12 17:45 [PATCH 00/10] AMD Cryptographic Coprocessor support Tom Lendacky
2013-11-12 17:46 ` [PATCH 01/10] crypto: authenc - Find proper IV address in ablkcipher callback Tom Lendacky
2013-11-28 14:18   ` Herbert Xu
2013-11-12 17:46 ` [PATCH 02/10] crypto: scatterwalk - Set the chain pointer indication bit Tom Lendacky
2013-11-28 14:21   ` Herbert Xu [this message]
2015-01-20  8:06     ` [PATCH] crypto: replace scatterwalk_sg_next with sg_next Cristian Stoica
2015-01-26  2:55       ` Herbert Xu
2013-11-12 17:46 ` [PATCH 03/10] crypto: CCP device driver and interface support Tom Lendacky
2013-11-12 17:46 ` [PATCH 04/10] crypto: crypto API interface to the CCP device driver Tom Lendacky
2013-11-12 17:46 ` [PATCH 05/10] crypto: CCP AES crypto API support Tom Lendacky
2013-11-12 17:46 ` [PATCH 06/10] crypto: CCP AES CMAC mode " Tom Lendacky
2013-11-12 17:46 ` [PATCH 07/10] crypto: CCP XTS-AES " Tom Lendacky
2013-11-12 17:46 ` [PATCH 08/10] crypto: CCP SHA " Tom Lendacky
2013-11-12 17:46 ` [PATCH 09/10] crytpo: CCP device driver build files Tom Lendacky
2013-11-12 17:46 ` [PATCH 10/10] crypto: CCP maintainer information Tom Lendacky
2013-11-20 16:20 ` [PATCH 00/10] AMD Cryptographic Coprocessor support Tom Lendacky
2013-11-21  3:20   ` Herbert Xu
2013-12-05 14:35 ` Herbert Xu
  -- strict thread matches above, loose matches on Subject: below --
2013-11-12 17:39 Tom Lendacky
2013-11-12 17:39 ` [PATCH 02/10] crypto: scatterwalk - Set the chain pointer indication bit Tom Lendacky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131128142130.GC32124@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=davem@davemloft.net \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thomas.lendacky@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®