From: "Theodore Ts'o" <tytso@mit.edu>
To: Greg Price <price@mit.edu>
Cc: linux-kernel@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH 7/9] random: forget lock in lockless accounting
Date: Fri, 29 Nov 2013 20:10:23 -0500 [thread overview]
Message-ID: <20131130011023.GG3778@thunk.org> (raw)
In-Reply-To: <20131113080828.GU16018@ringworld.MIT.EDU>
On Wed, Nov 13, 2013 at 03:08:28AM -0500, Greg Price wrote:
> The only mutable data accessed here is ->entropy_count, but since
> 902c098a3 ("random: use lockless techniques in the interrupt path")
> that member isn't protected by the lock anyway. Since 10b3a32d2
> ("random: fix accounting race condition") we use cmpxchg to protect
> our accesses to ->entropy_count here. Drop the use of the lock.
Applied, with a slight change to clarify the commit description:
The only mutable data accessed here is ->entropy_count, but since
10b3a32d2 ("random: fix accounting race condition") we use cmpxchg to
protect our accesses to ->entropy_count here. Drop the use of the
lock.
Thanks!
- Ted
next prev parent reply other threads:[~2013-11-30 1:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 8:07 [PATCH v2 0/9] random: code cleanups Greg Price
2013-11-13 8:07 ` [PATCH 1/9] random: fix typos / spelling errors in comments Greg Price
2013-11-29 19:56 ` Theodore Ts'o
2013-11-13 8:07 ` [PATCH 2/9] random: fix comment on proc_do_uuid Greg Price
2013-11-29 19:59 ` Theodore Ts'o
2013-11-13 8:07 ` [PATCH 3/9] random: fix description of get_random_bytes Greg Price
2013-11-29 20:00 ` Theodore Ts'o
2013-11-13 8:07 ` [PATCH 4/9] random: simplify loop in random_read Greg Price
2013-11-29 20:09 ` Theodore Ts'o
2013-11-30 5:30 ` Greg Price
2013-11-13 8:08 ` [PATCH 5/9] random: fix comment on "account" Greg Price
2013-11-29 20:53 ` Theodore Ts'o
2013-11-13 8:08 ` [PATCH 6/9] random: simplify accounting logic Greg Price
2013-11-30 1:04 ` Theodore Ts'o
2013-11-13 8:08 ` [PATCH 7/9] random: forget lock in lockless accounting Greg Price
2013-11-30 1:10 ` Theodore Ts'o [this message]
2013-11-13 8:08 ` [PATCH 8/9] random: tighten bound on random_read_wakeup_thresh Greg Price
2013-12-06 0:31 ` Theodore Ts'o
2013-11-13 8:08 ` [PATCH 9/9] random: simplify accounting code Greg Price
2013-12-06 1:13 ` Theodore Ts'o
2013-12-06 18:25 ` Greg Price
2013-12-07 14:48 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131130011023.GG3778@thunk.org \
--to=tytso@mit.edu \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=price@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome