From: Borislav Petkov <bp@alien8.de>
To: Levente Kurusa <levex@linux.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Tony Luck <tony.luck@intel.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, EDAC <linux-edac@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: mcheck: call put_device on device_register failure
Date: Sat, 30 Nov 2013 12:12:14 +0100 [thread overview]
Message-ID: <20131130111214.GB4323@pd.tnic> (raw)
In-Reply-To: <52999419.7040600@linux.com>
On Sat, Nov 30, 2013 at 08:30:33AM +0100, Levente Kurusa wrote:
> No, if the call to put_device gives up the last reference to the
> device, then device_release gets called which in turn frees the memory
> associated with it. In this case, mce_device_release() will get
> called, which is just a simple kfree call.
Aah, that's that delayed freeing the driver core does, right. Now you
made me go and look into detail:
device_unregister
|->put_device
|->kobject_put
|->kref_put(&kobj->kref, kobject_release)
|->kref_sub(kref, 1, release)
|->release
|->kobject_release
|->kobject_cleanup
|->t->release
|->device_release
|->mce_device_release
Ok, I see it now. :-) :-)
Thanks, I'll take your patch as-is.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-11-30 11:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 20:28 Levente Kurusa
2013-11-29 20:56 ` Borislav Petkov
2013-11-30 7:30 ` Levente Kurusa
2013-11-30 11:12 ` Borislav Petkov [this message]
2013-11-30 11:25 ` Levente Kurusa
2013-11-30 11:32 ` Borislav Petkov
2013-11-30 11:44 ` Levente Kurusa
2013-11-30 12:08 ` Borislav Petkov
2013-11-30 12:37 ` Levente Kurusa
2013-12-03 2:23 ` Chen, Gong
2013-12-03 17:01 ` Borislav Petkov
2013-12-04 7:38 ` Chen, Gong
2013-12-04 18:39 ` Levente Kurusa
2013-12-05 2:57 ` Chen, Gong
2013-12-05 11:18 ` Levente Kurusa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131130111214.GB4323@pd.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=levex@linux.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®