From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752655Ab3K3Qtn (ORCPT ); Sat, 30 Nov 2013 11:49:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:18222 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751760Ab3K3Qtm (ORCPT ); Sat, 30 Nov 2013 11:49:42 -0500 Date: Sat, 30 Nov 2013 17:49:21 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Corey Ashford , Frederic Weisbecker , Ingo Molnar , Namhyung Kim , Paul Mackerras , Peter Zijlstra , Steven Rostedt , David Ahern Subject: Re: [PATCH 06/29] tools lib traceevent: Add jbd2 plugin Message-ID: <20131130164921.GC1228@krava.brq.redhat.com> References: <1385638408-23519-1-git-send-email-jolsa@redhat.com> <1385638408-23519-7-git-send-email-jolsa@redhat.com> <20131129184235.GA12850@ghostprotocols.net> <20131129193113.GA13490@ghostprotocols.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131129193113.GA13490@ghostprotocols.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 29, 2013 at 04:31:13PM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Nov 29, 2013 at 03:42:35PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Thu, Nov 28, 2013 at 12:33:05PM +0100, Jiri Olsa escreveu: > > > This plugin adds field resolving functions for following tracepoint events: > > > jbd2:jbd2_checkpoint_stats > > > jbd2:jbd2_run_stats > > > > The diff of 'perf script' output generated by old and new code: > > > (data was generated by 'perf record -e 'jbd2:jbd2_run_stats,jbd2:jbd2_checkpoint_stats' -a') > > > The lines after one that starts with > > > --- > > > are ignored by 'git am', please ident them with at least one space, > > I'm doing that this time. > > > > > --- script.jbd2.old > > > +++ script.jbd2.new > > Also I just tried: > > [acme@ssdandy linux]$ git log --oneline | head -7 > b0496b02fcea tools lib traceevent: Add hrtimer plugin > 1ec7a71e0b2c tools lib traceevent: Add jbd2 plugin > c63100c95c6e tools lib traceevent: Add traceevent_host_bigendian function > d54b335656b7 tools lib traceevent: Add plugin build support > e796a0d73bcc tools lib traceevent: Add plugin support > 28c803842250 perf tools: Include test-stackprotector-all.c in test-all > 1a69f6ce513d perf timechart: Move wake_events list to 'struct timechart' > [acme@ssdandy linux]$ > > [acme@ssdandy linux]$ time make O=/tmp/build/perf -C tools/perf/ install > > > [acme@ssdandy linux]$ ls -la ~/.traceevent > ls: cannot access /home/acme/.traceevent: No such file or directory > [acme@ssdandy linux]$ > > Where did the plugins go? At least two should be there by now, no? At this stage (patches applied) you'd need to run the make for traceevent directory. The perf installation link is done within this patch: perf tools: Add build and install plugins targets which I presume you haven't applied yet? jirka