From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751403Ab3K3V2V (ORCPT ); Sat, 30 Nov 2013 16:28:21 -0500 Received: from mail.fireflyinternet.com ([87.106.93.118]:55404 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750975Ab3K3V2U (ORCPT ); Sat, 30 Nov 2013 16:28:20 -0500 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.73.22; Date: Sat, 30 Nov 2013 21:28:10 +0000 From: Chris Wilson To: Jan Engelhardt Cc: daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org, Linux Kernel Mailing List Subject: Re: i915: pipe state still does not match Message-ID: <20131130212810.GA12866@nuc-i3427.alporthouse.com> Mail-Followup-To: Chris Wilson , Jan Engelhardt , daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org, Linux Kernel Mailing List References: <20131127110836.GA6087@nuc-i3427.alporthouse.com> <20131129104825.GE27806@nuc-i3427.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 30, 2013 at 05:31:34PM +0100, Jan Engelhardt wrote: > > On Friday 2013-11-29 11:48, Chris Wilson wrote: > >> What I could collect so far: > > > >Thanks, I broke the handling of cropped XvImages along the fast paths. > >It should be fixed by: > > > >commit fd007d9d465b9b3ddbbaf769931ec921a6f5ecb8 > >Author: Chris Wilson > >Date: Thu Nov 28 21:13:33 2013 +0000 > > > > sna/video: Correct handling of cropped images along packed fast path > > I didn't manage to crash X within an hour, so that's commit is looking > good. > > The kernel error message for i915 pipe state however still appears - > namely, whenever the X server is terminating, including "reasonably > proper" terminations induced with sending SIGTERM to the X process. > Could it be that the i915 module does not handle sudden shutdowns > (which however can occur at any time) of the /dev/dri/cardN file > descriptor well enough? I'd say it was just the KMS transition from the X mode to the fbcon mode that triggers the inconsistent state warning. The warning is just that the hardware state after the mode change does not match our expectations - often this is a result of a buggy state readback, but sometimes it does indicate a more severe bug in our mode programming. -Chris -- Chris Wilson, Intel Open Source Technology Centre