mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Dave Jones <davej@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	gregkh@linuxfoundation.org
Subject: Re: sysfs: use a separate locking class for open files depending on mmap
Date: Tue, 3 Dec 2013 16:36:49 -0500	[thread overview]
Message-ID: <20131203213649.GO8277@htj.dyndns.org> (raw)
In-Reply-To: <20131203211515.GA17951@redhat.com>

Hey,

On Tue, Dec 03, 2013 at 04:15:15PM -0500, Dave Jones wrote:
>  > > Somehow I just triggered this trace again, even with this commit applied.
>  > > The trace is pretty much identical to the old one.
>  > 
>  > Hah, ain't that weird.  That's the trace you reported on the other
>  > mail, right?  I'll follow up on that one.
> 
> just so there's no doubt, here's a fresh one.

Argh, found the culprit.  The unified mmap path grabs of->mutex to
check whether the file implements mmap, which means that if you try to
mmap a file which doesn't implement mmap, you still add the locking
dependency.  I'm working on the fix.

Thanks.

-- 
tejun

  reply	other threads:[~2013-12-03 21:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20131128051223.45739660885@gitolite.kernel.org>
2013-12-03 18:43 ` Dave Jones
2013-12-03 21:10   ` Tejun Heo
2013-12-03 21:15     ` Dave Jones
2013-12-03 21:36       ` Tejun Heo [this message]
2013-12-03 22:15         ` Tejun Heo
2013-12-04  4:43           ` Dave Jones
2013-12-04 14:06             ` [PATCH driver-core-linus] sysfs: bail early from sysfs_bin_mmap() to avoid spurious lockdep warning Tejun Heo
2013-12-04 14:13               ` Tejun Heo
2013-12-04 14:20                 ` [PATCH driver-core-linus] sysfs: give different locking key to regular and bin files Tejun Heo
2013-12-05 19:44                   ` Greg KH
2013-12-05 19:52                     ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131203213649.GO8277@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=davej@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®