From: Mark Brown <broonie@kernel.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Stefan Agner <stefan@agner.ch>,
swarren@wwwdotorg.org, thierry.reding@gmail.com, dev@lynxeye.de,
lgirdwood@gmail.com, kai.poggensee@avionic-design.de,
sameo@linux.intel.com, linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/3] mfd: tps6586x: add version detection
Date: Wed, 4 Dec 2013 11:49:09 +0000 [thread overview]
Message-ID: <20131204114909.GK29268@sirena.org.uk> (raw)
In-Reply-To: <20131204100728.GA907@lee--X1>
[-- Attachment #1: Type: text/plain, Size: 645 bytes --]
On Wed, Dec 04, 2013 at 10:07:28AM +0000, Lee Jones wrote:
> On Wed, 04 Dec 2013, Stefan Agner wrote:
> > As I pointed out in the comment above, the struct tps6586x is in the C
> > file, so I would need to move that too. That's why I did not made that
> > change in the end. What do you think, should I still move (and move the
> > struct too?)
> Why would the struct have to be moved if the function is inline?
If the function is in the header and trying to use a struct that's only
defined in the C file then it's not going to build - keeping the struct
in the C file only does seem like a worthwhile thing for encapsulation.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-04 11:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 22:18 [PATCH v4 0/3] regulator: tps6586x: add version detection and voltage tables Stefan Agner
2013-12-03 22:18 ` [PATCH v4 1/3] mfd: tps6586x: add version detection Stefan Agner
2013-12-04 8:10 ` Lee Jones
2013-12-04 8:40 ` Stefan Agner
2013-12-04 10:07 ` Lee Jones
2013-12-04 11:38 ` Stefan Agner
2013-12-04 11:48 ` Lee Jones
2013-12-04 11:49 ` Mark Brown [this message]
2013-12-04 11:58 ` Lee Jones
2013-12-05 17:06 ` Stephen Warren
2013-12-05 17:43 ` Stefan Agner
2013-12-05 17:40 ` Stephen Warren
2013-12-05 22:56 ` Stefan Agner
2013-12-06 8:44 ` Lee Jones
2013-12-03 22:18 ` [PATCH v4 2/3] regulator: tps6586x: add and use correct voltage table Stefan Agner
2013-12-04 9:48 ` Thierry Reding
2013-12-04 12:14 ` Mark Brown
2013-12-04 14:17 ` Stefan Agner
2013-12-04 14:29 ` Mark Brown
2013-12-04 14:40 ` Lee Jones
2013-12-05 17:10 ` Stephen Warren
2013-12-03 22:18 ` [PATCH v4 3/3] ARM: tegra: correct Colibri T20 regulator settings Stefan Agner
2013-12-04 11:52 ` Lucas Stach
2013-12-05 17:12 ` Stephen Warren
2013-12-05 17:33 ` Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204114909.GK29268@sirena.org.uk \
--to=broonie@kernel.org \
--cc=dev@lynxeye.de \
--cc=kai.poggensee@avionic-design.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=stefan@agner.ch \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®