From: Mark Brown <broonie@kernel.org>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Jingoo Han <jg1.han@samsung.com>,
"'Liam Girdwood'" <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, "'Axel Lin'" <axel.lin@ingics.com>
Subject: Re: [PATCH 4/6] regulator: gpio-regulator: use devm_regulator_register()
Date: Fri, 6 Dec 2013 12:09:07 +0000 [thread overview]
Message-ID: <20131206120907.GE29268@sirena.org.uk> (raw)
In-Reply-To: <201312061012.05535.heiko@sntech.de>
[-- Attachment #1: Type: text/plain, Size: 470 bytes --]
On Fri, Dec 06, 2013 at 10:12:05AM +0100, Heiko Stübner wrote:
> I'm not this firm in the core driver/device behaviour, but when looking at
> __device_release_driver I see that the remove callback runs before
> devres_release_all, which would effectively free the gpios before the
> regulator gets unregistered - is this racy with a regulator change at the same
> time?
Yes, the rest of the driver really needs to be converted to devm_ at the
same time.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-06 12:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 7:07 [PATCH 1/6] regulator: ab8500: " Jingoo Han
2013-12-06 7:08 ` [PATCH 2/6] regulator: db8500-prcmu: " Jingoo Han
2013-12-06 8:35 ` Bengt Jönsson
2013-12-09 17:41 ` Mark Brown
2013-12-06 7:09 ` [PATCH 3/6] regulator: fixed: " Jingoo Han
2013-12-09 17:44 ` Mark Brown
2013-12-10 6:08 ` Jingoo Han
2013-12-06 7:10 ` [PATCH 4/6] regulator: gpio-regulator: " Jingoo Han
2013-12-06 9:12 ` Heiko Stübner
2013-12-06 12:09 ` Mark Brown [this message]
2013-12-09 2:01 ` Jingoo Han
2013-12-06 7:11 ` [PATCH 5/6] regulator: pfuze100: " Jingoo Han
2013-12-09 2:36 ` yibin.gong
2013-12-09 17:42 ` Mark Brown
2013-12-06 7:12 ` [PATCH 6/6] regulator: stw481x-vmmc: " Jingoo Han
2013-12-09 8:33 ` Linus Walleij
2013-12-09 17:26 ` Mark Brown
2013-12-06 8:26 ` [PATCH 1/6] regulator: ab8500: " Lee Jones
2013-12-09 17:38 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206120907.GE29268@sirena.org.uk \
--to=broonie@kernel.org \
--cc=axel.lin@ingics.com \
--cc=heiko@sntech.de \
--cc=jg1.han@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®