From: Dave Martin <Dave.Martin@arm.com>
To: Anurag Aggarwal <anurag19aggarwal@gmail.com>
Cc: Anurag Aggarwal <a.anurag@samsung.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"cpgs@samsung.com" <cpgs@samsung.com>,
"narendra.m1@samsung.com" <narendra.m1@samsung.com>,
"poorva.s@samsung.com" <poorva.s@samsung.com>,
"naveen.sel@samsung.com" <naveen.sel@samsung.com>,
"ashish.kalra@samsung.com" <ashish.kalra@samsung.com>,
"mohammad.a2@samsung.com" <mohammad.a2@samsung.com>,
"rajat.suri@samsung.com" <rajat.suri@samsung.com>,
"naveenkrishna.ch@gmail.com" <naveenkrishna.ch@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Will Deacon <Will.Deacon@arm.com>,
"nico@linaro.org" <nico@linaro.org>,
Catalin Marinas <Catalin.Marinas@arm.com>
Subject: Re: [PATCH V4] ARM : unwinder : Prevent data abort due to stack overflow
Date: Fri, 6 Dec 2013 15:21:41 +0000 [thread overview]
Message-ID: <20131206152140.GB4897@e103592.cambridge.arm.com> (raw)
In-Reply-To: <CAPoNrtuzV=eOWP44om+E6m0NSx+xfFtg-STjPLMBO4OUBF84kQ@mail.gmail.com>
On Thu, Dec 05, 2013 at 03:15:22PM +0000, Anurag Aggarwal wrote:
> >>if (unlikely(check) &&
> >> *vsp >= (unsigned long *)ctrl->sp_high))
>
> Good idea, It can help in optimizing the code and will leave code more readable
> and it will be easy to maintain also.
That was my goal -- it's not always easy to achieve both, but we should
try where possible, especially for non-performance-critical code.
> >>Does the code check anywhere that SP is word-aligned?
> >>
> >>That should probably be checked if it's not done already.
>
> I think this should be handled in separate patch
> I would also like to hear more your ideas for the file
There are some limitations on how backtracing works with ARM_UNWIND.
The backtracer interface assumes that the compiler's register use with
ARM_UNWIND is "almost the same" as with !ARM_UNWIND. But this is not
always true, and we've seen some problems.
I think the best solution will involve some refactoring of the interface
between the backtracer and the unwinder backends, but I don't have it
all figured out yet...
Cheers
---Dave
prev parent reply other threads:[~2013-12-06 15:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 11:26 Anurag Aggarwal
2013-12-05 13:59 ` Dave Martin
2013-12-05 15:15 ` Anurag Aggarwal
2013-12-06 15:21 ` Dave Martin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206152140.GB4897@e103592.cambridge.arm.com \
--to=dave.martin@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=Will.Deacon@arm.com \
--cc=a.anurag@samsung.com \
--cc=anurag19aggarwal@gmail.com \
--cc=ashish.kalra@samsung.com \
--cc=cpgs@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mohammad.a2@samsung.com \
--cc=narendra.m1@samsung.com \
--cc=naveen.sel@samsung.com \
--cc=naveenkrishna.ch@gmail.com \
--cc=nico@linaro.org \
--cc=poorva.s@samsung.com \
--cc=rajat.suri@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®