From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760293Ab3LICYn (ORCPT ); Sun, 8 Dec 2013 21:24:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:11872 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760165Ab3LICYk (ORCPT ); Sun, 8 Dec 2013 21:24:40 -0500 Date: Mon, 9 Dec 2013 10:23:36 +0800 From: Dave Young To: Borislav Petkov Cc: mjg59@srcf.ucam.org, linux-efi@vger.kernel.org, toshi kani , matt@console-pimps.org, greg@kroah.com, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, James Bottomley , horms@verge.net.au, ebiederm@xmission.com, hpa@zytor.com, vgoyal@redhat.com Subject: Re: [PATCH v4 06/12] efi: export efi runtime memory mapping to sysfs Message-ID: <20131209022335.GA3761@dhcp-16-126.nay.redhat.com> References: <1385445477-9665-1-git-send-email-dyoung@redhat.com> <1385445477-9665-7-git-send-email-dyoung@redhat.com> <20131127114402.GB32267@pd.tnic> <20131129094034.GI4186@dhcp-16-126.nay.redhat.com> <20131129115029.GB4266@pd.tnic> <20131202025942.GF3999@dhcp-16-126.nay.redhat.com> <20131202094020.GA7380@pd.tnic> <2141297830.13051543.1386406862068.JavaMail.root@redhat.com> <20131207133048.GA4183@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131207133048.GA4183@pd.tnic> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/07/13 at 02:30pm, Borislav Petkov wrote: > On Sat, Dec 07, 2013 at 04:01:02AM -0500, Dave Young wrote: > > Hi, all > > > > Update my status: > > > > I have finished most of thecode related changes including the krealloc > > fixes (both for original code and my new code). And I'm slowly > > moving the kexec related stuff to efi_kexec.c, this involves > > some other cleanups, such as: > > efi_systab_init: > > -> move 64bit code to efi_64.c, move 32bit code to efi_32.c > > > > efi_setup global variable is changing to physical address, ioremapping > > it when necessary instead of directly using the virt addr because > > previously the virt addr will be freed until entering virtual mode, > > it's possible a leak in case something is wrong in the middle also it > > occupies the ioremap slot a little bit long. > > > > There's also other problems, so I still need a few days probably > > a week to carefully restructure the code. > > Those are all lofty goals but beware that trying to solve it all at > once can be very painful and can cause unnecessary work for both coders > and reviewers. Especially if the patchset grows out of proportion which > makes it much harder to review and deal with. > > So, from my experience and if I were you, I'd try to address the most > important issue I'm trying to fix, have 10ish nice clean patches and put > the rest on the TODO list. This is much easier to deal with for everyone > involved than trying to solve it all at once. > > Besides, if you solve it all at once, what are you going to work on > afterwards? :-) > I like your suggestion for splitting kexec stuff to another file efi_kexec.c. but yes it needs more work and is bloating the patchset, I'm fine to leave it in TODO list. Thanks Dave