From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932310Ab3LIIxB (ORCPT ); Mon, 9 Dec 2013 03:53:01 -0500 Received: from mga01.intel.com ([192.55.52.88]:58176 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755451Ab3LIIwy (ORCPT ); Mon, 9 Dec 2013 03:52:54 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.93,856,1378882800"; d="scan'208";a="446849564" Date: Mon, 9 Dec 2013 10:52:45 +0200 From: Heikki Krogerus To: Felipe Balbi Cc: Roger Quadros , Kishon Vijay Abraham I , gregkh@linuxfoundation.org, rob.herring@calxeda.com, pawel.moll@arm.com, mark.rutland@arm.com, swarren@wwwdotorg.org, ijc+devicetree@hellion.org.uk, rob@landley.net, bcousson@baylibre.com, tony@atomide.com, linux@arm.linux.org.uk, grant.likely@linaro.org, s.nawrocki@samsung.com, galak@codeaurora.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v2 1/7] usb: dwc3: get "usb_phy" only if the platform indicates the presence of PHY's Message-ID: <20131209085245.GB5231@xps8300> References: <1381866857-3861-1-git-send-email-kishon@ti.com> <1381866857-3861-2-git-send-email-kishon@ti.com> <525E8E93.9010503@ti.com> <525E9046.3090209@ti.com> <525E943E.3080706@ti.com> <20131017145425.GE11611@gimli> <20131203103950.GB26423@xps8300> <20131206201530.GA21086@saruman.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131206201530.GA21086@saruman.home> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, Dec 06, 2013 at 02:15:30PM -0600, Felipe Balbi wrote: > On Tue, Dec 03, 2013 at 12:39:50PM +0200, Heikki Krogerus wrote: > > On Thu, Oct 17, 2013 at 09:54:26AM -0500, Felipe Balbi wrote: > > > On Wed, Oct 16, 2013 at 04:27:26PM +0300, Roger Quadros wrote: > > > > On 10/16/2013 04:10 PM, Kishon Vijay Abraham I wrote: > > > > Do you know if there are users of dwc3 other than exynos5250 and omap5? > > > > If not, we should get rid of the old USB PHY altogether. > > > > > > Intel's Baytrail, at least. But they don't use DT. > > > > I don't see any use for the generic-phy when the device is enumerated > > from PCI. If dwc3 can live without phys, there should not be any > > problem dropping the old USB PHY support. > > yeah, I don't want to drop PHY support, I want to require everybody to > provide a PHY, otherwise we have too many options to handle and that's > never clean. I have to clarify in case there was a misunderstanding. When I said generic-phy I meant drivers/usb/phy/phy-generic.c and I was not talking about Kishon's new generic PHY framework. So I was only saying that if the dwc3-pci.c is the only thing that needs the old usb phy support, then there should not be any problem dropping the support for it. Thanks, -- heikki