From: Jiri Olsa <jolsa@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Borislav Petkov <bp@suse.de>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Robert Richter <rric@kernel.org>
Subject: Re: [PATCH 2/2] tools/: Move fs.* to lib/api/fs/
Date: Mon, 9 Dec 2013 11:26:50 +0100 [thread overview]
Message-ID: <20131209102650.GD1242@krava.brq.redhat.com> (raw)
In-Reply-To: <1386260752-16436-3-git-send-email-bp@alien8.de>
On Thu, Dec 05, 2013 at 05:25:52PM +0100, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
>
> Move to generic library and kill magic.h as it is needed only in fs.h.
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> ---
> tools/lib/api/Makefile | 2 ++
> tools/{perf/util => lib/api/fs}/fs.c | 11 ++++++++---
> tools/{perf/util/include/linux/magic.h => lib/api/fs/fs.h} | 12 +++++-------
> tools/perf/Makefile.perf | 3 ---
> tools/perf/tests/parse-events.c | 2 +-
> tools/perf/util/cpumap.c | 2 +-
> tools/perf/util/fs.h | 7 -------
> tools/perf/util/pmu.c | 2 +-
> tools/perf/util/python-ext-sources | 2 +-
> tools/perf/util/record.c | 2 +-
> 10 files changed, 20 insertions(+), 25 deletions(-)
> rename tools/{perf/util => lib/api/fs}/fs.c (91%)
> rename tools/{perf/util/include/linux/magic.h => lib/api/fs/fs.h} (50%)
> delete mode 100644 tools/perf/util/fs.h
>
> diff --git a/tools/lib/api/Makefile b/tools/lib/api/Makefile
> index d749cdc8e1d4..2a354292d781 100644
> --- a/tools/lib/api/Makefile
> +++ b/tools/lib/api/Makefile
> @@ -8,8 +8,10 @@ LIB_H=
> LIB_OBJS=
>
> LIB_H += fs/debugfs.h
> +LIB_H += fs/fs.h
>
> LIB_OBJS += $(OUTPUT)fs/debugfs.o
> +LIB_OBJS += $(OUTPUT)fs/fs.o
>
> LIBFILE = libapikfs.a
>
> diff --git a/tools/perf/util/fs.c b/tools/lib/api/fs/fs.c
> similarity index 91%
> rename from tools/perf/util/fs.c
> rename to tools/lib/api/fs/fs.c
> index f5be1f26e724..ff8907275cfb 100644
> --- a/tools/perf/util/fs.c
> +++ b/tools/lib/api/fs/fs.c
> @@ -1,8 +1,13 @@
> +/* TODO merge/factor into debugfs.c */
I guess now above one should be:
TODO merge/factor debugfs object in here
;-)
jirka
next prev parent reply other threads:[~2013-12-09 10:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 16:25 [PATCH 0/2] perf tool: Carve out fs.* stuff Borislav Petkov
2013-12-05 16:25 ` [PATCH 1/2] tools/: Convert to new topic libraries Borislav Petkov
2013-12-09 10:22 ` Jiri Olsa
2013-12-09 10:42 ` Borislav Petkov
2013-12-05 16:25 ` [PATCH 2/2] tools/: Move fs.* to lib/api/fs/ Borislav Petkov
2013-12-09 10:26 ` Jiri Olsa [this message]
2013-12-09 10:43 ` Borislav Petkov
2013-12-05 17:47 ` [PATCH 0/2] perf tool: Carve out fs.* stuff Arnaldo Carvalho de Melo
2013-12-08 17:42 ` David Ahern
2013-12-09 10:39 ` Borislav Petkov
2013-12-09 10:30 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131209102650.GD1242@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@infradead.org \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rric@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome