From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934243Ab3LIQ16 (ORCPT ); Mon, 9 Dec 2013 11:27:58 -0500 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.226]:64816 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932636Ab3LIQ1n (ORCPT ); Mon, 9 Dec 2013 11:27:43 -0500 Date: Mon, 9 Dec 2013 11:27:42 -0500 From: Steven Rostedt To: Jiri Olsa Cc: Namhyung Kim , Arnaldo Carvalho de Melo , Frederic Weisbecker , Ingo Molnar , LKML , Namhyung Kim Subject: Re: [PATCH 06/14] tools lib traceevent: Get rid of malloc_or_die() in find_event() Message-ID: <20131209112742.38020666@gandalf.local.home> In-Reply-To: <20131209110350.GH1242@krava.brq.redhat.com> References: <1386567251-22751-1-git-send-email-namhyung@kernel.org> <1386567251-22751-7-git-send-email-namhyung@kernel.org> <20131209110350.GH1242@krava.brq.redhat.com> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.22; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 Dec 2013 12:03:50 +0100 Jiri Olsa wrote: > On Mon, Dec 09, 2013 at 02:34:03PM +0900, Namhyung Kim wrote: > > Make it return -2 to distinguish malloc allocation failure. > > > > Signed-off-by: Namhyung Kim > > --- > > tools/lib/traceevent/parse-filter.c | 17 ++++++++++++++--- > > 1 file changed, 14 insertions(+), 3 deletions(-) > > > > diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c > > index e9d17bfcdffd..06e5af9f8fc4 100644 > > --- a/tools/lib/traceevent/parse-filter.c > > +++ b/tools/lib/traceevent/parse-filter.c > > @@ -301,7 +301,10 @@ find_event(struct pevent *pevent, struct event_list **events, > > sys_name = NULL; > > } > > > > - reg = malloc_or_die(strlen(event_name) + 3); > > + reg = malloc(strlen(event_name) + 3); > > + if (reg == NULL) > > + return -2; > > + > > I guess we dont need error defines or enums when this is just > static function, but at least please add some comment (description) > of return values like in pevent_filter_match function Even for static functions, we should have an enum too. -- Steve