From: Jiri Olsa <jolsa@redhat.com>
To: Jean Pihet <jean.pihet@linaro.org>
Cc: linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org,
Ingo Molnar <mingo@kernel.org>, Arnaldo <acme@ghostprotocols.net>,
Will Deacon <will.deacon@arm.com>,
patches@linaro.org
Subject: Re: [PATCH 2/2] perf: unwinding: use the per-feature check flags
Date: Mon, 9 Dec 2013 18:17:19 +0100 [thread overview]
Message-ID: <20131209171719.GA16631@krava.brq.redhat.com> (raw)
In-Reply-To: <1386411461-21510-3-git-send-email-jean.pihet@linaro.org>
On Sat, Dec 07, 2013 at 11:17:41AM +0100, Jean Pihet wrote:
> Use the per-feature check flags for the unwinding feature in order
> to correctly compile the libunwind and libunwind-debug-frame feature
> checks.
>
> Tested on x86_64, ARMv7 and ARMv8 with and without LIBUNWIND_DIR set
> in 'make -C tools/perf'
>
> Signed-off-by: Jean Pihet <jean.pihet@linaro.org>
> Cc: Jiri Olsa <jolsa@redhat.com>
SNIP
> +BUILD = $(CC) $(CFLAGS) -o $(OUTPUT)$@ $@.c $(LDFLAGS)
>
> ###############################
>
> test-all:
> - $(BUILD) -Werror -fstack-protector -fstack-protector-all -O2 -Werror -D_FORTIFY_SOURCE=2 -ldw -lelf -lnuma $(LIBUNWIND_LIBS) -lelf -laudit -I/usr/include/slang -lslang $(shell pkg-config --libs --cflags gtk+-2.0 2>/dev/null) $(FLAGS_PERL_EMBED) $(FLAGS_PYTHON_EMBED) -DPACKAGE='"perf"' -lbfd -ldl
> + $(BUILD) -Werror -fstack-protector -fstack-protector-all -O2 -Werror -D_FORTIFY_SOURCE=2 -ldw -lelf -lnuma -lelf -laudit -I/usr/include/slang -lslang $(shell pkg-config --libs --cflags gtk+-2.0 2>/dev/null) $(FLAGS_PERL_EMBED) $(FLAGS_PYTHON_EMBED) -DPACKAGE='"perf"' -lbfd -ldl
hum, the test-all build command should have every possible flags we use, right?
including LIBUNWIND_CFLAGS, LIBUNWIND_LDFLAGS
also, this patch no longer applies on acme's perf/core
jirka
next prev parent reply other threads:[~2013-12-09 17:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-07 10:17 [PATCH v3 0/2] perf: config: add " Jean Pihet
2013-12-07 10:17 ` [PATCH 1/2] perf: " Jean Pihet
2013-12-07 10:17 ` [PATCH 2/2] perf: unwinding: use the " Jean Pihet
2013-12-09 17:17 ` Jiri Olsa [this message]
2013-12-09 18:02 ` Jean Pihet
2013-12-09 18:15 ` Jiri Olsa
2013-12-10 9:57 ` Jiri Olsa
2013-12-10 10:05 ` Jean Pihet
2013-12-10 10:13 ` Jiri Olsa
-- strict thread matches above, loose matches on Subject: below --
2013-12-10 12:24 [PATCH v4 0/2] perf: config: add " Jean Pihet
2013-12-10 12:24 ` [PATCH 2/2] perf: unwinding: use the " Jean Pihet
2013-12-03 16:09 [PATCH v2 0/2] perf: config: add " Jean Pihet
2013-12-03 16:09 ` [PATCH 2/2] perf: unwinding: use the " Jean Pihet
2013-11-21 14:52 [PATCH 0/2] perf: config: add " Jean Pihet
2013-11-21 14:52 ` [PATCH 2/2] perf: unwinding: use the " Jean Pihet
2013-11-26 17:58 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131209171719.GA16631@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@ghostprotocols.net \
--cc=jean.pihet@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=patches@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®