From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752097Ab3LJCNS (ORCPT ); Mon, 9 Dec 2013 21:13:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:21045 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750980Ab3LJCNP (ORCPT ); Mon, 9 Dec 2013 21:13:15 -0500 Date: Tue, 10 Dec 2013 10:12:21 +0800 From: Dave Young To: Borislav Petkov Cc: "H. Peter Anvin" , Ingo Molnar , linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, x86@kernel.org, mjg59@srcf.ucam.org, James.Bottomley@HansenPartnership.com, vgoyal@redhat.com, ebiederm@xmission.com, horms@verge.net.au, kexec@lists.infradead.org, greg@kroah.com, matt@console-pimps.org, toshi.kani@hp.com Subject: Re: [PATCH v5 01/14] x86/mm: sparse warning fix for early_memremap Message-ID: <20131210021221.GA3800@dhcp-16-126.nay.redhat.com> References: <1386582147-9802-1-git-send-email-dyoung@redhat.com> <1386582147-9802-2-git-send-email-dyoung@redhat.com> <20131209150521.GE31650@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131209150521.GE31650@pd.tnic> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/09/13 at 04:05pm, Borislav Petkov wrote: > On Mon, Dec 09, 2013 at 05:42:14PM +0800, Dave Young wrote: > > There's a lot of sparse warnings for code like below: > > void *a = early_memremap(phys_addr, size); > > > > early_memremap intend to map kernel memory with ioremap facility, the return > > pointer should be a kernel ram pointer instead of iomem one. > > > > For making the function clearer and supressing sparse warnings this patch > > do below two things: > > 1. cast to (__force void *) for the return value of early_memremap > > I'd guess this is to shut up the __iomem thing? And we're getting that > because we're using ioremap, ... hohum... Yes, IMHO early_memremap really should not return __iomem pointer since it's *memremap*... Thanks Dave