From: Andrew Morton <akpm@linux-foundation.org>
To: Rui Xiang <rui.xiang@huawei.com>
Cc: <linux-kernel@vger.kernel.org>, Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH RESEND 1/2] proc: change return values while get_proc_task err
Date: Tue, 10 Dec 2013 15:02:41 -0800 [thread overview]
Message-ID: <20131210150241.5b741b8754112b1ab6d3abd6@linux-foundation.org> (raw)
In-Reply-To: <1386591115-39392-1-git-send-email-rui.xiang@huawei.com>
On Mon, 9 Dec 2013 20:11:54 +0800 Rui Xiang <rui.xiang@huawei.com> wrote:
> While getting proc task error, it shoule return -ESRCH.
>
> ...
>
> --- a/fs/proc/base.c
> +++ b/fs/proc/base.c
> @@ -174,9 +174,10 @@ static int get_task_root(struct task_struct *task, struct path *root)
> static int proc_cwd_link(struct dentry *dentry, struct path *path)
> {
> struct task_struct *task = get_proc_task(dentry->d_inode);
> - int result = -ENOENT;
> + int result = -ESRCH;
I suppose so. But there is risk here of breaking existing applications
and I don't think this problem is serious enough to justify that risk?
next prev parent reply other threads:[~2013-12-10 23:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 12:11 Rui Xiang
2013-12-09 12:11 ` [PATCH RESEND 2/2] proc: set attributes of pde by accessor functions Rui Xiang
2013-12-10 23:02 ` Andrew Morton [this message]
2013-12-11 5:55 ` [PATCH RESEND 1/2] proc: change return values while get_proc_task err Rui Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131210150241.5b741b8754112b1ab6d3abd6@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rui.xiang@huawei.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®