From: Andi Kleen <andi@firstfloor.org>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, x86@kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/2] x86, microcode: Do Intel microcode revision check signed
Date: Tue, 10 Dec 2013 16:55:33 +0100 [thread overview]
Message-ID: <20131210155533.GI21717@two.firstfloor.org> (raw)
In-Reply-To: <20131210153000.GA3804@phenom.dumpdata.com>
On Tue, Dec 10, 2013 at 10:30:00AM -0500, Konrad Rzeszutek Wilk wrote:
> On Fri, Dec 06, 2013 at 01:04:02PM -0800, Andi Kleen wrote:
> > From: Andi Kleen <ak@linux.intel.com>
> >
> > The Intel SDM Vol 3 9.11.1 Microcode update states that
> > the update revision field is signed. However we do the comparison
> > unsigned, as the comparison gets promoted.
> >
> > Use a cast to really do a signed comparison of the microcode
> > revision.
>
> Why not just update the struct?
It would need updating various printks I think. So I chose the simpler cast,
as that already solves the comparison problem.
-Andi
next prev parent reply other threads:[~2013-12-10 15:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 21:04 Andi Kleen
2013-12-06 21:04 ` [PATCH 2/2] x86, microcode: Add option to allow downgrading of microcode Andi Kleen
2013-12-13 21:00 ` Henrique de Moraes Holschuh
2013-12-15 0:40 ` Henrique de Moraes Holschuh
2013-12-10 15:30 ` [PATCH 1/2] x86, microcode: Do Intel microcode revision check signed Konrad Rzeszutek Wilk
2013-12-10 15:55 ` Andi Kleen [this message]
2013-12-10 17:09 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131210155533.GI21717@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome