From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751065Ab3LKJBa (ORCPT ); Wed, 11 Dec 2013 04:01:30 -0500 Received: from cantor2.suse.de ([195.135.220.15]:39686 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750736Ab3LKJB3 (ORCPT ); Wed, 11 Dec 2013 04:01:29 -0500 Date: Wed, 11 Dec 2013 09:01:24 +0000 From: Mel Gorman To: Wanpeng Li Cc: Andrew Morton , Ingo Molnar , Rik van Riel , Peter Zijlstra , Naoya Horiguchi , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v5 4/8] sched/numa: fix set cpupid on page migration twice against normal page Message-ID: <20131211090124.GR11295@suse.de> References: <1386723001-25408-1-git-send-email-liwanp@linux.vnet.ibm.com> <1386723001-25408-5-git-send-email-liwanp@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1386723001-25408-5-git-send-email-liwanp@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 11, 2013 at 08:49:57AM +0800, Wanpeng Li wrote: > commit 7851a45cd3 (mm: numa: Copy cpupid on page migration) copy over > the cpupid at page migration time, there is unnecessary to set it again > in function alloc_misplaced_dst_page, this patch fix it. > > Reviewed-by: Naoya Horiguchi > Signed-off-by: Wanpeng Li migratepages aops is not necessarily required to go through migrate_page_copy but in practice all of them do and it's hard to imagine one that didn't so. Acked-by: Mel Gorman -- Mel Gorman SUSE Labs