From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751631Ab3LKOsg (ORCPT ); Wed, 11 Dec 2013 09:48:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1609 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750904Ab3LKOsf (ORCPT ); Wed, 11 Dec 2013 09:48:35 -0500 Date: Wed, 11 Dec 2013 09:47:58 -0500 From: Richard Guy Briggs To: John Johansen Cc: Peter Zijlstra , Oleg Nesterov , linux-kernel@vger.kernel.org, linux-audit@redhat.com, Ingo Molnar , "Serge E. Hallyn" Subject: Re: [PATCH 03/12] pid: get ppid pid_t of task in init_pid_ns safely Message-ID: <20131211144758.GA1160@madcap2.tricolour.ca> References: <20130827172155.GC29147@redhat.com> <20130830195646.GJ21110@madcap2.tricolour.ca> <52210275.8040601@canonical.com> <20130903183159.GA28517@madcap2.tricolour.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130903183159.GA28517@madcap2.tricolour.ca> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 03, 2013 at 02:31:59PM -0400, Richard Guy Briggs wrote: > On Fri, Aug 30, 2013 at 01:37:09PM -0700, John Johansen wrote: > > On 08/30/2013 12:56 PM, Richard Guy Briggs wrote: > > > On Tue, Aug 27, 2013 at 07:21:55PM +0200, Oleg Nesterov wrote: > > >> On 08/20, Richard Guy Briggs wrote: > > > Most of the instances are current, but the one called from apparmour is > > > stored. I've just learned that this is bad and someone else just chimed > > > in that they have a patch to remove it... > > > > the apparmor case isn't actually stored long term. The stored task will be > > a parameter that was passed into an lsm hook and the buffer that it is > > stored in dies before the hook is done. Its temporarily stored in the > > struct so that it can be passed into the lsm_audit fn, and printed into an > > allocated audit buffer. The text version in the audit buffer is what will > > exist beyond the hook. > > > > There are three patches, I'll reply them below once I have finished rebasing > > them to apply to the current tree instead of my dev tree. > > John, thanks for this context and fix. That helps simplify things. John, What's the status of this set of 3 patches? I don't see them upstream. > - RGB - RGB -- Richard Guy Briggs Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat Remote, Ottawa, Canada Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545