Re: [PATCH 1/2] perf completion: complete 'perf kvm'

[Arnaldo Carvalho de Melo <acme@redhat.com>]

Em Wed, Dec 11, 2013 at 04:04:15PM +0530, Ramkumar Ramachandra escreveu:
> Currently, there is no way to enumerate the subcommands under 'perf
> kvm', so hardcode them.

[acme@ssdandy linux]$ perf kvm -h 2>&1 | grep usage
 usage: perf kvm [<options>] {top|record|report|diff|buildid-list|stat}

Can't you use this somehow?

I'm applying it tho as it is better than the current situation.

- Arnaldo
 
> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
> ---
>  tools/perf/perf-completion.sh | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/perf/perf-completion.sh b/tools/perf/perf-completion.sh
> index 4949488..496e2ab 100644
> --- a/tools/perf/perf-completion.sh
> +++ b/tools/perf/perf-completion.sh
> @@ -121,6 +121,10 @@ __perf_main ()
>  	elif [[ $prev == "-e" && "${words[1]}" == @(record|stat|top) ]]; then
>  		evts=$($cmd list --raw-dump)
>  		__perfcomp_colon "$evts" "$cur"
> +	# List subcommands for 'perf kvm'
> +	elif [[ $prev == "kvm" ]]; then
> +		subcmds="top record report diff buildid-list stat"
> +		__perfcomp_colon "$subcmds" "$cur"
>  	# List long option names
>  	elif [[ $cur == --* ]];  then
>  		subcmd=${words[1]}
> -- 
> 1.8.5.rc0.5.g70ebc73.dirty