From: Thierry Reding <thierry.reding@gmail.com>
To: Paul Walmsley <pwalmsley@nvidia.com>
Cc: "Mikko Perttunen" <mperttunen@nvidia.com>,
"Arto Merilainen" <amerilainen@nvidia.com>,
"Terje Bergström" <tbergstrom@nvidia.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] gpu: host1x: clk_round_rate() can return a zero upon error
Date: Thu, 12 Dec 2013 12:03:44 +0100 [thread overview]
Message-ID: <20131212110343.GA11524@ulmo.nvidia.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1312091746400.4127@tamien>
[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]
On Mon, Dec 09, 2013 at 06:00:12PM -0800, Paul Walmsley wrote:
>
> Treat both negative and zero return values from clk_round_rate() as
> errors. This is needed since subsequent patches will convert
> clk_round_rate()'s return value to be an unsigned type, rather than a
> signed type, since some clock sources can generate rates higher than
> (2^31)-1 Hz.
>
> Eventually, when calling clk_round_rate(), only a return value of zero
> will be considered a error. All other values will be considered valid
> rates. The comparison against values less than 0 is kept to preserve
> the correct behavior in the meantime.
>
> Signed-off-by: Paul Walmsley <pwalmsley@nvidia.com>
> Cc: Mikko Perttunen <mperttunen@nvidia.com>
> Cc: Arto Merilainen <amerilainen@nvidia.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Terje Bergström <tbergstrom@nvidia.com>
> ---
> Applies on v3.13-rc3. See also:
>
> http://marc.info/?l=linux-arm-kernel&m=138542591313620&w=2
>
> drivers/gpu/drm/tegra/hdmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-12-12 11:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 2:00 Paul Walmsley
2013-12-11 7:51 ` Sascha Hauer
2013-12-11 7:55 ` Paul Walmsley
2013-12-11 15:19 ` Thierry Reding
2013-12-11 19:15 ` Paul Walmsley
2013-12-12 11:03 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131212110343.GA11524@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=amerilainen@nvidia.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=pwalmsley@nvidia.com \
--cc=tbergstrom@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome