From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Matt Porter <mporter@linaro.org>
Cc: Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Kumar Gala <galak@codeaurora.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Christian Daudt <bcm@fixthebug.org>,
Paul Zimmerman <paulz@synopsys.com>,
Devicetree List <devicetree@vger.kernel.org>,
Kamil Debski <k.debski@samsung.com>,
Linaro Patches <patches@linaro.org>,
Tomasz Figa <t.figa@samsung.com>,
Linux USB List <linux-usb@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 1/9] phy: add phy_get_bus_width()/phy_set_bus_width() calls
Date: Thu, 12 Dec 2013 11:27:15 +0000 [thread overview]
Message-ID: <20131212112715.GK4360@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1386847117-21240-2-git-send-email-mporter@linaro.org>
On Thu, Dec 12, 2013 at 06:18:29AM -0500, Matt Porter wrote:
> /**
> + * struct phy_attrs - represents phy attributes
> + * @bus_width: Data path width implemented by PHY
> + */
> +struct phy_attrs {
> + u32 bus_width;
Why u32?
> int phy_power_off(struct phy *phy);
> +static inline u32 phy_get_bus_width(struct phy *phy)
> +{
> + return phy->attrs.bus_width;
...
>
> +static inline u32 phy_get_bus_width(struct phy *phy)
> +{
> + return -ENOSYS;
Why u32, especially as you're returning a negative number here.
If the bus width is a small integer (I'm assuming you don't have up to
2^30 bus signals) then what's wrong with it being an 'int' ?
next prev parent reply other threads:[~2013-12-12 11:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 11:18 [PATCH v4 0/9] USB Device Controller support for BCM281xx Matt Porter
2013-12-12 11:18 ` [PATCH v4 1/9] phy: add phy_get_bus_width()/phy_set_bus_width() calls Matt Porter
2013-12-12 11:27 ` Russell King - ARM Linux [this message]
2013-12-12 11:50 ` Matt Porter
2013-12-12 11:18 ` [PATCH v4 2/9] staging: dwc2: update DT binding to add generic clock/phy properties Matt Porter
2013-12-12 11:18 ` [PATCH v4 3/9] usb: gadget: s3c-hsotg: enable build for other platforms Matt Porter
2013-12-12 11:18 ` [PATCH v4 4/9] usb: gadget: s3c-hsotg: add snps,dwc2 compatible string Matt Porter
2013-12-12 11:18 ` [PATCH v4 5/9] usb: gadget: s3c-hsotg: use generic phy_init()/phy_exit() support Matt Porter
2013-12-12 11:18 ` [PATCH v4 6/9] usb: gadget: s3c-hsotg: get phy bus width from phy subsystem Matt Porter
2013-12-12 11:18 ` [PATCH v4 7/9] phy: add Broadcom Kona USB2 PHY DT binding Matt Porter
2013-12-12 11:18 ` [PATCH v4 8/9] phy: add Broadcom Kona USB2 PHY driver Matt Porter
2013-12-12 11:18 ` [PATCH v4 9/9] ARM: dts: add usb udc support to bcm281xx Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131212112715.GK4360@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=balbi@ti.com \
--cc=bcm@fixthebug.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=k.debski@samsung.com \
--cc=kishon@ti.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mporter@linaro.org \
--cc=patches@linaro.org \
--cc=paulz@synopsys.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®