From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751782Ab3LLNjm (ORCPT ); Thu, 12 Dec 2013 08:39:42 -0500 Received: from mail-qe0-f46.google.com ([209.85.128.46]:64283 "EHLO mail-qe0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751618Ab3LLNjj (ORCPT ); Thu, 12 Dec 2013 08:39:39 -0500 Date: Thu, 12 Dec 2013 08:39:35 -0500 From: Tejun Heo To: "Robin H. Johnson" Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Subject: Re: [PATCH] libata: provide the ability to disable a disk via the params. Message-ID: <20131212133935.GA32683@htj.dyndns.org> References: <1386464187-6993-1-git-send-email-robbat2@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1386464187-6993-1-git-send-email-robbat2@gentoo.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Robin. On Sat, Dec 07, 2013 at 04:56:27PM -0800, Robin H. Johnson wrote: > + { "disable", .horkage_on = ATA_HORKAGE_DISABLE }, > + { "nodisable", .horkage_off = ATA_HORKAGE_DISABLE }, Given the current usage of ATA_HORKAGE_DISABLE, I don't think we need "nodisable". Let's just add "disable" for now. Can you please update the patch and resend? Thanks. -- tejun