mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Vladimir Davydov <vdavydov@parallels.com>
Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
	devel@openvz.org, Li Zefan <lizefan@huawei.com>
Subject: Re: [PATCH] cgroup: fix fail path in cgroup_load_subsys()
Date: Thu, 12 Dec 2013 10:35:36 -0500	[thread overview]
Message-ID: <20131212153536.GD32683@htj.dyndns.org> (raw)
In-Reply-To: <1386403085-24866-1-git-send-email-vdavydov@parallels.com>

On Sat, Dec 07, 2013 at 11:58:05AM +0400, Vladimir Davydov wrote:
> We should not call cgroup_unload_subsys() if online_css() fails, because
> online_css() does not assign css to cgroup on failure, while
> offline_css() called from cgroup_unload_subsys() expects it is assigned.
> So let's call everything we need to rollback inline without involving
> cgroup_unload_subsys().
> 
> Signed-off-by: Vladimir Davydov <vdavydov@parallels.com>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Li Zefan <lizefan@huawei.com>

Applied to cgroup/for-3.13-fixes.

Thanks.

-- 
tejun

  parent reply	other threads:[~2013-12-12 15:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-07  7:58 Vladimir Davydov
2013-12-12  6:01 ` Li Zefan
2013-12-12 15:35 ` Tejun Heo [this message]
2013-12-12 15:55   ` Tejun Heo
2013-12-12 18:37     ` Vladimir Davydov
2013-12-12 18:45       ` Tejun Heo
2013-12-12 18:51         ` Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131212153536.GD32683@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=devel@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=vdavydov@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®