From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: David Miller <davem@davemloft.net>
Cc: vyasevich@gmail.com, dvlasenk@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru,
jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
jpirko@redhat.com
Subject: Re: [patch net-next v2] ipv6: log autoconfiguration failures
Date: Thu, 12 Dec 2013 20:00:42 +0100 [thread overview]
Message-ID: <20131212190042.GH4675@order.stressinduktion.org> (raw)
In-Reply-To: <20131212.132441.1907656115241279246.davem@davemloft.net>
On Thu, Dec 12, 2013 at 01:24:41PM -0500, David Miller wrote:
> From: Vlad Yasevich <vyasevich@gmail.com>
> Date: Thu, 12 Dec 2013 12:58:18 -0500
>
> > On 12/12/2013 12:22 PM, David Miller wrote:
> >> Give it statistics just like we have for every other kind of similar
> >> event.
> >
> > The fact that link-local address could not be generated for a specific
> > device type does not lend itself well to counting. There is no way
> > from to tell from the counter which device does not support IPv6 autoconfig.
>
> If the statistic is per-device, which I recommended it be implemented as,
> you indeed can.
>
> And I do not buy the argument that this is "useless" because the admin
> is just going to kill the interface and create a new one. When you
> notice there is a problem, you look at the statistics before doing
> that!
Granted.
IMHO both ways are fine with a slight opionion to counters being overkill. ;)
next prev parent reply other threads:[~2013-12-12 19:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 11:45 Denys Vlasenko
2013-12-11 19:21 ` Hannes Frederic Sowa
2013-12-11 20:54 ` David Miller
2013-12-11 21:09 ` Hannes Frederic Sowa
2013-12-12 11:28 ` Denys Vlasenko
2013-12-12 17:24 ` David Miller
2013-12-12 11:17 ` Denys Vlasenko
2013-12-12 17:22 ` David Miller
2013-12-12 17:58 ` Vlad Yasevich
2013-12-12 18:24 ` David Miller
2013-12-12 19:00 ` Hannes Frederic Sowa [this message]
2013-12-12 19:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131212190042.GH4675@order.stressinduktion.org \
--to=hannes@stressinduktion.org \
--cc=davem@davemloft.net \
--cc=dvlasenk@redhat.com \
--cc=jmorris@namei.org \
--cc=jpirko@redhat.com \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vyasevich@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®