From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751909Ab3LLVEy (ORCPT ); Thu, 12 Dec 2013 16:04:54 -0500 Received: from mail.skyhub.de ([78.46.96.112]:46328 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751825Ab3LLVEt (ORCPT ); Thu, 12 Dec 2013 16:04:49 -0500 Date: Thu, 12 Dec 2013 22:04:39 +0100 From: Borislav Petkov To: Dave Young Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, x86@kernel.org, mjg59@srcf.ucam.org, hpa@zytor.com, James.Bottomley@HansenPartnership.com, vgoyal@redhat.com, ebiederm@xmission.com, horms@verge.net.au, kexec@lists.infradead.org, greg@kroah.com, matt@console-pimps.org, toshi.kani@hp.com Subject: Re: [PATCH v5 09/14] efi: passing kexec necessary efi data via setup_data Message-ID: <20131212210439.GB30162@pd.tnic> References: <1386582147-9802-1-git-send-email-dyoung@redhat.com> <1386582147-9802-10-git-send-email-dyoung@redhat.com> <20131211222057.GB8863@pd.tnic> <20131212030619.GG3751@dhcp-16-126.nay.redhat.com> <20131212071743.GJ3751@dhcp-16-126.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20131212071743.GJ3751@dhcp-16-126.nay.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 12, 2013 at 03:17:43PM +0800, Dave Young wrote: > Rethink about this issue, moving them to efi_$(BITS).c I need move the > efi_setup from a static variable to an extern, It looks not worth. Dave, would you please do what is suggested to you? A big part of the efi code is split into 32-bit and 64-bit functionality. If you have a serious argument why it shouldn't be done so then sure, by all means, but stop coming up with silly arguments like having an extern declaration is a bad thing. Please. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --