Re: [PATCH] drm/bochs: new driver

["Stefan Lippers-Hollmann" <s.L-H@gmx.de>]

Hi

On Thursday 12 December 2013, Gerd Hoffmann wrote:
> DRM driver for (virtual) vga cards using the bochs dispi
> interface, such as the qemu standard vga (qemu -vga std).
> 
> Don't bother supporting anything but 32bpp for now, even
> though the virtual hardware is able to do that.
> 
> Known issue: mmap(/dev/fb0) doesn't work.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
[…]
> diff --git a/drivers/gpu/drm/bochs/bochs_mm.c b/drivers/gpu/drm/bochs/bochs_mm.c
> new file mode 100644
> index 0000000..afe104f
> --- /dev/null
> +++ b/drivers/gpu/drm/bochs/bochs_mm.c
[…]
> +int bochs_gem_create(struct drm_device *dev, u32 size, bool iskernel,
> +		     struct drm_gem_object **obj)
> +{
> +	struct bochs_bo *bochsbo;
> +	int ret;
> +
> +	*obj = NULL;
> +
> +	size = roundup(size, PAGE_SIZE);
[…]

Using roundup() this way will fail to build in 32 bit architectures/ 
i386:

ERROR: "__udivdi3" [drivers/gpu/drm/bochs/bochs-drm.ko] undefined!
ERROR: "__umoddi3" [drivers/gpu/drm/bochs/bochs-drm.ko] undefined!

[drm/bochs works pretty nicely for me on amd64]

Regards
	Stefan Lippers-Hollmann