mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: David Miller <davem@davemloft.net>
Cc: dvlasenk@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru,
	jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
	jpirko@redhat.com
Subject: Re: [patch net-next v3] ipv6: log autoconfiguration failures
Date: Sat, 14 Dec 2013 11:39:29 +0100	[thread overview]
Message-ID: <20131214103929.GE23563@order.stressinduktion.org> (raw)
In-Reply-To: <20131213.175709.414078764436451428.davem@davemloft.net>

On Fri, Dec 13, 2013 at 05:57:09PM -0500, David Miller wrote:
> From: Denys Vlasenko <dvlasenk@redhat.com>
> Date: Fri, 13 Dec 2013 16:45:47 +0100
> 
> > If ipv6 auto-configuration does not work, currently it's hard
> > to track what's going on. This change adds log messages
> > (at debug level) on every code path where ipv6 autoconf fails.
> > 
> > v3: changed pr_debug's to pr_warn's.
> > 
> > Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
> 
> I already made it clear I want to see statistics added instead of log
> messages for this.

Hmm... I gave this a bit more thought.

I would go with counters, too. What if we add something like per interface
softerror states. So that we e.g. can see that one protocol had an error on an
interface and it needs attention of an administrator?

E.g.

2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP,SOFT_FAIL>

Would catch the eyes more quickly. If counters are implemented we could
do that completly in user space and add that flag as soon as one of the
observed counters are above 0 (and of course, iproute needs colors).

What do you think?


      reply	other threads:[~2013-12-14 10:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-13 15:45 Denys Vlasenko
2013-12-13 16:48 ` Vlad Yasevich
2013-12-13 22:57 ` David Miller
2013-12-14 10:39   ` Hannes Frederic Sowa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131214103929.GE23563@order.stressinduktion.org \
    --to=hannes@stressinduktion.org \
    --cc=davem@davemloft.net \
    --cc=dvlasenk@redhat.com \
    --cc=jmorris@namei.org \
    --cc=jpirko@redhat.com \
    --cc=kaber@trash.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®