From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752286Ab3LPBv5 (ORCPT ); Sun, 15 Dec 2013 20:51:57 -0500 Received: from am1ehsobe004.messaging.microsoft.com ([213.199.154.207]:38225 "EHLO am1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752111Ab3LPBvz (ORCPT ); Sun, 15 Dec 2013 20:51:55 -0500 X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI X-SpamScore: 2 X-BigFish: VS2(z579eh551biz98dI1432Ic8kzz1f42h2148h208ch1ee6h1de0h1fdah2073h2146h1202h1e76h2189h1d1ah1d2ah1fc6hzz1de098h8275bh1de097hz2dh2a8h839h944hd25hf0ah1220h1288h12a5h12a9h12bdh137ah13b6h1441h1504h1537h153bh162dh1631h1758h18e1h1946h19b5h1ad9h1b0ah1b2fh2222h224fh1fb3h1d0ch1d2eh1d3fh1dfeh1dffh1fe8h1ff5h209eh2216h22d0h2336h1155h) Date: Mon, 16 Dec 2013 09:19:05 +0800 From: Peter Chen To: CC: , Subject: Re: [PATCH 1/3] usb: chipidea: add support for USB OTG controller on LSI Zevio SoCs Message-ID: <20131216011904.GB14183@shlinux1.ap.freescale.net> References: <1387078509-14156-1-git-send-email-dt.tangr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1387078509-14156-1-git-send-email-dt.tangr@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-OriginatorOrg: freescale.com X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 15, 2013 at 02:35:07PM +1100, dt.tangr@gmail.com wrote: > From: Daniel Tang > > The USB controller in TI-NSPIRE calculators (LSI Zevio SoC) are based off either > Freescale's USB OTG controller or the USB controller found in the IMX233, both > of which are Chipidea compatible. > > This patch adds a device tree binding for the controller. > > Signed-off-by: Daniel Tang > --- > drivers/usb/chipidea/Makefile | 1 + > drivers/usb/chipidea/ci_hdrc_zevio.c | 72 ++++++++++++++++++++++++++++++++++ > 2 files changed, 73 insertions(+) > create mode 100644 drivers/usb/chipidea/ci_hdrc_zevio.c > > diff --git a/drivers/usb/chipidea/Makefile b/drivers/usb/chipidea/Makefile > index a99d980..7635407 100644 > --- a/drivers/usb/chipidea/Makefile > +++ b/drivers/usb/chipidea/Makefile > @@ -10,6 +10,7 @@ ci_hdrc-$(CONFIG_USB_CHIPIDEA_DEBUG) += debug.o > # Glue/Bridge layers go here > > obj-$(CONFIG_USB_CHIPIDEA) += ci_hdrc_msm.o > +obj-$(CONFIG_USB_CHIPIDEA) += ci_hdrc_zevio.o > > # PCI doesn't provide stubs, need to check > ifneq ($(CONFIG_PCI),) > diff --git a/drivers/usb/chipidea/ci_hdrc_zevio.c b/drivers/usb/chipidea/ci_hdrc_zevio.c > new file mode 100644 > index 0000000..3bf6489 > --- /dev/null > +++ b/drivers/usb/chipidea/ci_hdrc_zevio.c > @@ -0,0 +1,72 @@ > +/* > + * Copyright (C) 2013 Daniel Tang > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2, as > + * published by the Free Software Foundation. > + * > + * Based off drivers/usb/chipidea/ci_hdrc_msm.c > + * > + */ > + > +#include > +#include > +#include > +#include > + > +#include "ci.h" > + > +static struct ci_hdrc_platform_data ci_hdrc_zevio_platdata = { > + .name = "ci_hdrc_zevio", > + .flags = CI_HDRC_REGS_SHARED, > + .capoffset = DEF_CAPOFFSET, > +}; > + > +static int ci_hdrc_zevio_probe(struct platform_device *pdev) > +{ > + struct platform_device *ci_pdev; > + > + dev_dbg(&pdev->dev, "ci_hdrc_zevio_probe\n"); > + > + ci_pdev = ci_hdrc_add_device(&pdev->dev, > + pdev->resource, pdev->num_resources, > + &ci_hdrc_zevio_platdata); > + > + if (IS_ERR(ci_pdev)) { > + dev_err(&pdev->dev, "ci_hdrc_add_device failed!\n"); > + return PTR_ERR(ci_pdev); > + } > + > + platform_set_drvdata(pdev, ci_pdev); > + > + return 0; > +} > + > +static int ci_hdrc_zevio_remove(struct platform_device *pdev) > +{ > + struct platform_device *ci_pdev = platform_get_drvdata(pdev); > + > + ci_hdrc_remove_device(ci_pdev); > + > + return 0; > +} > + > +static const struct of_device_id ci_hdrc_zevio_dt_ids[] = { > + { .compatible = "lsi,zevio-usb", }, > + { /* sentinel */ } > +}; > + > +static struct platform_driver ci_hdrc_zevio_driver = { > + .probe = ci_hdrc_zevio_probe, > + .remove = ci_hdrc_zevio_remove, > + .driver = { > + .name = "zevio_usb", > + .owner = THIS_MODULE, > + .of_match_table = ci_hdrc_zevio_dt_ids, > + }, > +}; > + > +MODULE_DEVICE_TABLE(of, ci_hdrc_zevio_dt_ids); > +module_platform_driver(ci_hdrc_zevio_driver); > + > +MODULE_LICENSE("GPL v2"); > -- The driver patch is okay for me, please cc me your dt patch next time, I will apply it when your dt patches are applied by dt maintainer (or any of your dt strings "zevio_xxx" are applied). -- Best Regards, Peter Chen