From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753145Ab3LPKzg (ORCPT ); Mon, 16 Dec 2013 05:55:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34513 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753007Ab3LPKze (ORCPT ); Mon, 16 Dec 2013 05:55:34 -0500 Date: Mon, 16 Dec 2013 08:55:15 -0200 From: Rafael Aquini To: Joonsoo Kim Cc: Andrew Morton , Mel Gorman , Rik van Riel , Naoya Horiguchi , Christoph Lameter , Joonsoo Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka , Zhang Yanfei , Wanpeng Li Subject: Re: [PATCH v3 1/6] mm/migrate: add comment about permanent failure path Message-ID: <20131216105514.GA16165@localhost.localdomain> References: <1386917611-11319-1-git-send-email-iamjoonsoo.kim@lge.com> <1386917611-11319-2-git-send-email-iamjoonsoo.kim@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1386917611-11319-2-git-send-email-iamjoonsoo.kim@lge.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 13, 2013 at 03:53:26PM +0900, Joonsoo Kim wrote: > From: Naoya Horiguchi > > Let's add a comment about where the failed page goes to, which makes > code more readable. > > Acked-by: Christoph Lameter > Reviewed-by: Wanpeng Li > Signed-off-by: Naoya Horiguchi > Signed-off-by: Joonsoo Kim > > diff --git a/mm/migrate.c b/mm/migrate.c > index 3747fcd..c6ac87a 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1123,7 +1123,12 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page, > nr_succeeded++; > break; > default: > - /* Permanent failure */ > + /* > + * Permanent failure (-EBUSY, -ENOSYS, etc.): > + * unlike -EAGAIN case, the failed page is > + * removed from migration page list and not > + * retried in the next outer loop. > + */ > nr_failed++; > break; > } Acked-by: Rafael Aquini