mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ahci: bail out on ICH6 before using AHCI BAR
Date: Mon, 16 Dec 2013 10:46:11 -0500	[thread overview]
Message-ID: <20131216154611.GE32509@htj.dyndns.org> (raw)
In-Reply-To: <1387190061.9255.30.camel@x41.thuisdomein>

On Mon, Dec 16, 2013 at 11:34:21AM +0100, Paul Bolle wrote:
> The check for "combined mode" (which disables ahci support) on ICH6 is
> done after the first use of AHCI BAR. But if ahci is not enabled AHCI
> BAR is initialized to 0x00000000. (At least it is on the ICH6-M I tested
> this on. If I understand the datasheet correctly it should also be on
> ICH6R.) This apparently makes the call of
> pcim_iomap_regions_request_all() return -EINVAL. And we end up with
>     ahci: probe of 0000:00:1f.2 failed with error -22
> 
> (at warning level) in the logs.
> 
> So check for "combined mode" before calling
> pcim_iomap_regions_request_all().
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>

Applied to libata/for-3.13-fixes.

Thanks.

-- 
tejun

      reply	other threads:[~2013-12-16 15:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-16 10:34 Paul Bolle
2013-12-16 15:46 ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131216154611.GE32509@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®