From: Jeff Layton <jlayton@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
nfs-ganesha-devel@lists.sourceforge.net,
samba-technical@lists.samba.org
Subject: Re: [PATCH v3 6/6] locks: add new "private" lock type that is owned by the filp
Date: Tue, 17 Dec 2013 08:50:55 -0500 [thread overview]
Message-ID: <20131217085055.1e89965c@tlielax.poochiereds.net> (raw)
In-Reply-To: <20131217133721.GA16724@infradead.org>
On Tue, 17 Dec 2013 05:37:21 -0800
Christoph Hellwig <hch@infradead.org> wrote:
> On Tue, Dec 17, 2013 at 08:31:25AM -0500, Jeff Layton wrote:
> > So, I think the above semantics are pretty clear, but now that I've had
> > a go at sitting down to document this stuff for the POSIX spec and
> > manpages, it's clear how convoluted the text in there is becoming.
> >
> > That makes me wonder...would we be better off with a new set of cmd
> > values here instead of new l_type values? IOW, we could add new:
> >
> > F_GETLKP
> > F_SETLKP
> > F_SETLKPW
>
> That seems a tad cleaner to me indeed.
>
> > ...and then just reuse the same F_RDLCK/F_WRLCK/F_UNLCK values? With
> > that too, we could create a new equivalent to struct flock that has
> > fixed length types instead of dealing with the off_t mess.
>
> For the Posix interface you'd need an off_t as that's what the whole
> API uses for file offsets. We could make sure to always use a off64_t
> for the kernel interface though.
>
Ok.
> What is the API you propose to posix? An new posix_lockf?
>
I haven't proposed anything concrete to POSIX just yet. I'm trying to
get the Linux patches done and then I'll do that. I don't think we want
a new syscall when fcntl() will work.
If we use new cmd values however, then we don't necessarily need to use
struct flock/flock64. I think the question is -- should we stick with
struct flock/flock64, or would we be better served with something new
for this?
Thanks,
--
Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2013-12-17 13:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 19:17 [PATCH v3 0/6] locks: implement "filp-private" (aka UNPOSIX) locks Jeff Layton
2013-12-10 19:17 ` [PATCH v3 1/6] locks: consolidate common code in the flock_to_posix_lock routines Jeff Layton
2013-12-10 21:22 ` J. Bruce Fields
2013-12-10 23:22 ` J. Bruce Fields
2013-12-11 11:18 ` Jeff Layton
2013-12-11 14:37 ` J. Bruce Fields
2013-12-11 15:19 ` J. Bruce Fields
2013-12-11 16:54 ` Jeff Layton
2013-12-11 16:59 ` J. Bruce Fields
2013-12-11 18:09 ` Jeff Layton
2013-12-11 19:07 ` Jeff Layton
2013-12-11 22:56 ` J. Bruce Fields
2013-12-11 22:57 ` J. Bruce Fields
2013-12-12 10:43 ` Jeff Layton
2013-12-12 10:44 ` Jeff Layton
2014-01-05 20:39 ` J. Bruce Fields
2014-01-05 20:42 ` [PATCH] locks: fix posix lock range overflow handling J. Bruce Fields
2013-12-10 19:17 ` [PATCH v3 2/6] locks: consolidate checks for compatible filp->f_mode values in setlk handlers Jeff Layton
2013-12-10 19:17 ` [PATCH v3 3/6] locks: rename locks_remove_flock to locks_remove_file Jeff Layton
2013-12-10 19:17 ` [PATCH v3 4/6] locks: show private lock types in /proc/locks Jeff Layton
2013-12-10 19:17 ` [PATCH v3 5/6] locks: report l_pid as -1 for FL_FILE_PVT locks Jeff Layton
2013-12-10 19:31 ` Jeff Layton
2013-12-10 19:41 ` [Nfs-ganesha-devel] " Frank Filz
2013-12-10 19:57 ` Jeff Layton
2013-12-10 19:17 ` [PATCH v3 6/6] locks: add new "private" lock type that is owned by the filp Jeff Layton
2013-12-17 13:31 ` Jeff Layton
2013-12-17 13:37 ` Christoph Hellwig
2013-12-17 13:50 ` Jeff Layton [this message]
2013-12-10 19:30 ` [Nfs-ganesha-devel] [PATCH v3 0/6] locks: implement "filp-private" (aka UNPOSIX) locks Frank Filz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131217085055.1e89965c@tlielax.poochiereds.net \
--to=jlayton@redhat.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nfs-ganesha-devel@lists.sourceforge.net \
--cc=samba-technical@lists.samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®