From: Mark Brown <broonie@kernel.org>
To: "Anson.Huang@freescale.com" <Anson.Huang@freescale.com>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: anatop: add is_enabled interface
Date: Tue, 17 Dec 2013 13:53:05 +0000 [thread overview]
Message-ID: <20131217135305.GG3185@sirena.org.uk> (raw)
In-Reply-To: <242D3451-6B96-4A0E-88E0-44C4DCCD96FA@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 561 bytes --]
On Tue, Dec 17, 2013 at 01:10:12PM +0000, Anson.Huang@freescale.com wrote:
> > In any case I'd be much happier with this patch if it implemented the
> > enable and disable operations as well.
> understand now. then maybe I should remove the PU check in cpufreq,
> although setting PU LDO if it is off before would bring unnessary
> power leak. I will add all these changes together with the dynamic PU
> LDO management feature, thanks for your time!
If you've implemented the enable support correctly then setting the
voltage shouldn't enable the regulator.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-12-17 13:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 21:20 Anson Huang
2013-12-16 18:57 ` Mark Brown
2013-12-17 2:38 ` Anson.Huang
2013-12-17 12:29 ` Mark Brown
2013-12-17 12:38 ` Anson.Huang
2013-12-17 13:00 ` Mark Brown
2013-12-17 13:10 ` Anson.Huang
2013-12-17 13:53 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131217135305.GG3185@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Anson.Huang@freescale.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®